[MIRROR] Refactors team antagonists and roundend report handling [MDB IGNORE] (#16308)

* Refactors team antagonists and roundend report handling (#69585)

* Refactors team antagonists and roundend report handling

Refactors teams and subtypes
* Makes use of ``as anything`` and ``\improper``
* Removes many single letter variables
* Moves team code to the team file
* Makes team objectives only allow objectives for SpacemanDMM
* Makes members and objectives clear when a team is deleted
* Generalizes team's add_objective
* Checks for show_roundend_report in roundend
* Replaces ``get_team == src`` with a simple mind check
* Makes Bloodbrothers fit using parent's endround report.
* Removes the unused procs ``is_solo`` and ``antag_listing_footer``
* Makes replaces ``get_team_antag`` ``specific`` with ``include_subtypes`` to be consistent with Antag helpers (and because I thought it looked better that way)

* Refactors team antagonists and roundend report handling

* improper borers

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
This commit is contained in:
SkyratBot
2022-09-23 22:29:34 -04:00
committed by GitHub
co-authored by John Willard tastyfish
parent 44fb03430e
commit c8776ecbbb
13 changed files with 114 additions and 126 deletions
@@ -125,7 +125,7 @@
mob_mind.add_antag_datum(antag_datum_to_give, antag_team)
/datum/team/battlecruiser
name = "Battlecruiser Crew"
name = "\improper Battlecruiser Crew"
member_name = "crewmember"
/// The central objective of this battlecruiser
var/core_objective = /datum/objective/nuclear