cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-28 07:38:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

Bools and returns super-pr (#53221)

Browse Source 
Replaces like 70-80% of 0 and such, as a side effect cleaned up a bunch of returns
Edit: Most left out ones are in mecha which should be done in mecha refactor already
Oh my look how clean it is

Co-authored-by: TiviPlus <TiviPlus>
Co-authored-by: Couls <coul422@gmail.com>
This commit is contained in:
TiviPlus
2020-08-28 14:26:37 -07:00
committed by GitHub
co-authored by TiviPlus <TiviPlus> Couls
parent cb49d3301b
commit ca366c3ea1
355 changed files with 1549 additions and 1591 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/game/objects/items/storage/book.dm
+2 -2
View File
@@ -158,7 +158,7 @@ GLOBAL_LIST_INIT(bibleitemstates, list("bible", "koran", "scrapbook", "burning",
if (!heal_mode)
return ..()
var/smack = 1
var/smack = TRUE
if (M.stat != DEAD)
if(chaplain && user == M)
@@ -166,7 +166,7 @@ GLOBAL_LIST_INIT(bibleitemstates, list("bible", "koran", "scrapbook", "burning",
return
if(prob(60) && bless(M, user))
smack = 0
smack = FALSE
else if(iscarbon(M))
var/mob/living/carbon/C = M
if(!istype(C.head, /obj/item/clothing/head/helmet))
code/game/objects/items/storage/boxes.dm
+1 -1
View File
@@ -72,7 +72,7 @@
/obj/item/storage/box/attackby(obj/item/W, mob/user, params)
if(istype(W, /obj/item/stack/package_wrap))
return 0
return FALSE
return ..()
//Mime spell boxes
code/game/objects/items/storage/secure.dm
+11 -11
View File
@@ -17,9 +17,9 @@
var/icon_opened = "secure0"
var/code = ""
var/l_code = null
var/l_set = 0
var/l_setshort = 0
var/l_hacking = 0
var/l_set = FALSE
var/l_setshort = FALSE
var/l_hacking = FALSE
var/open = FALSE
w_class = WEIGHT_CLASS_NORMAL
desc = "This shouldn't exist. If it does, create an issue report."
@@ -44,15 +44,15 @@
if (W.tool_behaviour == TOOL_WIRECUTTER)
to_chat(user, "<span class='danger'>[src] is protected from this sort of tampering, yet it appears the internal memory wires can still be <b>pulsed</b>.</span>")
if ((W.tool_behaviour == TOOL_MULTITOOL) && (!l_hacking))
if(open == 1)
if(open == TRUE)
to_chat(user, "<span class='danger'>Now attempting to reset internal memory, please hold.</span>")
l_hacking = 1
l_hacking = TRUE
if (W.use_tool(src, user, 400))
to_chat(user, "<span class='danger'>Internal memory reset - lock has been disengaged.</span>")
l_set = 0
l_hacking = 0
l_set = FALSE
l_hacking = FALSE
else
l_hacking = 0
l_hacking = FALSE
else
to_chat(user, "<span class='warning'>You must <b>unscrew</b> the service panel before you can pulse the wiring!</span>")
return
@@ -84,10 +84,10 @@
return
if (href_list["type"])
if (href_list["type"] == "E")
if ((l_set == 0) && (length(code) == 5) && (!l_setshort) && (code != "ERROR"))
if (!l_set && (length(code) == 5) && (!l_setshort) && (code != "ERROR"))
l_code = code
l_set = 1
else if ((code == l_code) && (l_set == 1))
l_set = TRUE
else if ((code == l_code) && l_set)
SEND_SIGNAL(src, COMSIG_TRY_STORAGE_SET_LOCKSTATE, FALSE)
cut_overlays()
add_overlay(icon_opened)