[MIRROR] Random Station Smuggler Satchel Rebalance [MDB IGNORE] (#22330)

* Random Station Smuggler Satchel Rebalance (#76621)

## About The Pull Request

Rebalances the smuggler satchels that were randomly replaced around the
station.
Now only two are spawned, down from 10

## Why It's Good For The Game

Though I think these are cool, currently with 10 spawning roundstart
they feel like they are everywhere, especially if you are walking around
with t-ray vision. The smugglers satchel is powerful item, powerful
enough to be in the traitor uplink. It makes inventory management a lot
easier, as you essentially have another backpack in your backpack. I
feel like this is a fine reward for being lucky or actively looking for
them, but with how they are currently, you can pretty much guarantee
your chances of getting 5 with a t-ray scanner and a couple minutes of
walking around, invalidating the inventory system. Now if you want this
reward, you have to make a choice to look for one, with the knowledge
that you still may not find it.

## Changelog

🆑 Seven
balance: Only 2 smugglers satchels will spawn on the station at
roundstart, down from 10
/🆑

* Random Station Smuggler Satchel Rebalance

---------

Co-authored-by: Lufferly <40921881+Lufferly@users.noreply.github.com>
Co-authored-by: Bloop <vinylspiders@gmail.com>
This commit is contained in:
SkyratBot
2023-07-12 11:27:18 -04:00
committed by GitHub
co-authored by Lufferly Bloop
parent 3e67fbed60
commit ca36bc9345
+7 -5
View File
@@ -11,7 +11,7 @@ SUBSYSTEM_DEF(minor_mapping)
return SS_INIT_NO_NEED
#else
trigger_migration(CONFIG_GET(number/mice_roundstart))
place_satchels()
place_satchels(satchel_amount = 2)
return SS_INIT_SUCCESS
#endif // the mice are easily the bigger problem, but let's just avoid anything that could cause some bullshit.
@@ -42,19 +42,21 @@ SUBSYSTEM_DEF(minor_mapping)
var/turf_temperature = proposed_turf.temperature
return turf_gasmix.has_gas(/datum/gas/oxygen, 5) && turf_temperature < NPC_DEFAULT_MAX_TEMP && turf_temperature > NPC_DEFAULT_MIN_TEMP
/datum/controller/subsystem/minor_mapping/proc/place_satchels(amount=10)
/datum/controller/subsystem/minor_mapping/proc/place_satchels(satchel_amount)
var/list/turfs = find_satchel_suitable_turfs()
///List of areas where satchels should not be placed.
var/list/blacklisted_area_types = list(/area/station/holodeck)
var/list/blacklisted_area_types = list(
/area/station/holodeck,
)
while(turfs.len && amount > 0)
while(turfs.len && satchel_amount > 0)
var/turf/turf = pick_n_take(turfs)
if(is_type_in_list(get_area(turf), blacklisted_area_types))
continue
var/obj/item/storage/backpack/satchel/flat/flat_satchel = new(turf)
SEND_SIGNAL(flat_satchel, COMSIG_OBJ_HIDE, turf.underfloor_accessibility)
amount--
satchel_amount--
/proc/find_exposed_wires()
var/list/exposed_wires = list()