modules/atmospherics major cleanup (#61904)

major cleanup of modules/atmospherics folder and all related files, still many missing
-cleanup of procs name
-cleanup of vars name
-documentation of some of the procs
-minor changes to some for() logic (no in game changes just early continue or as anything checks)

No in game changes, only code and docs
This commit is contained in:
Ghilker
2021-10-14 10:13:57 +02:00
committed by GitHub
parent c4b60fda30
commit cb5fb1df2d
96 changed files with 3783 additions and 3726 deletions
@@ -11,7 +11,7 @@
use_power = NO_POWER_USE
interaction_flags_atom = NONE
interaction_flags_machine = NONE
CanAtmosPass = ATMOS_PASS_NO
can_atmos_pass = ATMOS_PASS_NO
light_range = 4
layer = ABOVE_OBJ_LAYER
///First of the generators producing the containment field
@@ -35,7 +35,7 @@
if(field_gen_2)
field_gen_2.fields -= src
field_gen_2 = null
CanAtmosPass = ATMOS_PASS_YES
can_atmos_pass = ATMOS_PASS_YES
air_update_turf(TRUE, FALSE)
return ..()
@@ -32,7 +32,7 @@ no power level overlay is currently in the overlays list.
density = TRUE
use_power = NO_POWER_USE
max_integrity = 500
CanAtmosPass = ATMOS_PASS_YES
can_atmos_pass = ATMOS_PASS_YES
//100% immune to lasers and energy projectiles since it absorbs their energy.
armor = list(MELEE = 25, BULLET = 10, LASER = 100, ENERGY = 100, BOMB = 0, BIO = 0, RAD = 0, FIRE = 50, ACID = 70)
///Amount of energy stored, used for visual overlays (over 9000?)
@@ -199,7 +199,7 @@ no power level overlay is currently in the overlays list.
/obj/machinery/field/generator/proc/turn_off()
active = FG_OFFLINE
CanAtmosPass = ATMOS_PASS_YES
can_atmos_pass = ATMOS_PASS_YES
air_update_turf(TRUE, FALSE)
INVOKE_ASYNC(src, .proc/cleanup)
addtimer(CALLBACK(src, .proc/cool_down), 5 SECONDS)
@@ -275,7 +275,7 @@ no power level overlay is currently in the overlays list.
turn_off()
return
move_resist = INFINITY
CanAtmosPass = ATMOS_PASS_NO
can_atmos_pass = ATMOS_PASS_NO
air_update_turf(TRUE, TRUE)
addtimer(CALLBACK(src, .proc/setup_field, 1), 1)
addtimer(CALLBACK(src, .proc/setup_field, 2), 2)
+2 -2
View File
@@ -29,7 +29,7 @@
icon_state = "compressor"
density = TRUE
resistance_flags = FIRE_PROOF
CanAtmosPass = ATMOS_PASS_DENSITY
can_atmos_pass = ATMOS_PASS_DENSITY
circuit = /obj/item/circuitboard/machine/power_compressor
var/obj/machinery/power/turbine/turbine
var/datum/gas_mixture/gas_contained
@@ -54,7 +54,7 @@
icon_state = "turbine"
density = TRUE
resistance_flags = FIRE_PROOF
CanAtmosPass = ATMOS_PASS_DENSITY
can_atmos_pass = ATMOS_PASS_DENSITY
circuit = /obj/item/circuitboard/machine/power_turbine
var/opened = 0
var/obj/machinery/power/compressor/compressor