From cc34f010822862f17b633de8ae358cd2ec6fc5e1 Mon Sep 17 00:00:00 2001 From: SmArtKar <44720187+SmArtKar@users.noreply.github.com> Date: Sat, 23 May 2026 17:17:12 +0200 Subject: [PATCH] Fixes plumbing ducts having weird shadows (#96102) ## About The Pull Request UPDATE_ICON is needed rather than UPDATE_ICON_STATE to update the emissive blocker Closes #96076 ## Changelog :cl: fix: Fixed plumbing ducts having weird shadows /:cl: --- code/datums/components/plumbing/_plumbing.dm | 4 ++-- code/modules/plumbing/ducts.dm | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/code/datums/components/plumbing/_plumbing.dm b/code/datums/components/plumbing/_plumbing.dm index f03e1d67866..cad8d5b935f 100644 --- a/code/datums/components/plumbing/_plumbing.dm +++ b/code/datums/components/plumbing/_plumbing.dm @@ -100,7 +100,7 @@ if(istype(duct)) if(duct.neighbours && (duct.duct_layer & ducting_layer)) duct.neighbours[parent] = opposite_dir - duct.update_appearance(UPDATE_ICON_STATE) + duct.update_appearance(UPDATE_ICON) duct.net.add_plumber(src, direction) continue @@ -123,7 +123,7 @@ for(var/obj/machinery/duct/pipe as anything in net.ducts) if(pipe.neighbours[parent]) pipe.neighbours -= parent - pipe.update_appearance(UPDATE_ICON_STATE) + pipe.update_appearance(UPDATE_ICON) //remove ourself from this network and delete it if emtpy if(net.remove_plumber(src)) diff --git a/code/modules/plumbing/ducts.dm b/code/modules/plumbing/ducts.dm index c2634d22f77..fe86c09e712 100644 --- a/code/modules/plumbing/ducts.dm +++ b/code/modules/plumbing/ducts.dm @@ -114,7 +114,7 @@ neighbours[other] = direction //connecting duct to us LAZYADDASSOC(other.neighbours, src, opposite_dir) - other.update_appearance(UPDATE_ICON_STATE) + other.update_appearance(UPDATE_ICON) continue @@ -138,7 +138,7 @@ //assign neighbour neighbours[plumbing.parent] = direction - update_appearance(UPDATE_ICON_STATE) + update_appearance(UPDATE_ICON) ///we disconnect ourself from our neighbours. we also destroy our ductnet and tell our neighbours to make a new one /obj/machinery/duct/on_deconstruction() @@ -168,7 +168,7 @@ var/obj/machinery/duct/pipe = neighbour if(istype(pipe)) pipe.neighbours -= src - pipe.update_appearance(UPDATE_ICON_STATE) + pipe.update_appearance(UPDATE_ICON) //find every node that can be reached from our neighbour making sure to not revisit it again in circles if(visited[neighbour])