From ccea3ccf309288347f613b294e377464760fa0b8 Mon Sep 17 00:00:00 2001 From: Lucy Date: Sat, 6 Jun 2026 12:24:45 -0400 Subject: [PATCH] fix a hard delete with loot panels (#96349) ## About The Pull Request fixes `/datum/lootpanel` not being removed from SSlooting's backlog/processing when destroyed. another native reftracker W ``` [2026-06-04 15:54:59.739] REFSCANNER: native refscan complete for /datum/lootpanel ([0x21068f2e]), took 942 ms - === 2 finding(s)=== - [list] list #5085 [index 0] (len=1, refs=1) - [list_owner] datum #1977 (/datum/controller/subsystem/looting).processing -> list #5085 ``` also fixed a bug where SSlooting wouldn't really process after `backlog` was moved to `processing`. ## Why It's Good For The Game hard delete bad ## Changelog no player-facing changes --- code/modules/lootpanel/_lootpanel.dm | 2 ++ code/modules/lootpanel/ss_looting.dm | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/code/modules/lootpanel/_lootpanel.dm b/code/modules/lootpanel/_lootpanel.dm index f7cfab8d8cd..cc67696d6f2 100644 --- a/code/modules/lootpanel/_lootpanel.dm +++ b/code/modules/lootpanel/_lootpanel.dm @@ -23,6 +23,8 @@ /datum/lootpanel/Destroy(force) + SSlooting.backlog -= src + SSlooting.processing -= src reset_contents() owner = null source_turf = null diff --git a/code/modules/lootpanel/ss_looting.dm b/code/modules/lootpanel/ss_looting.dm index eb8cff36e69..6f2481844a1 100644 --- a/code/modules/lootpanel/ss_looting.dm +++ b/code/modules/lootpanel/ss_looting.dm @@ -18,7 +18,7 @@ SUBSYSTEM_DEF(looting) /datum/controller/subsystem/looting/fire(resumed) - if(!length(backlog)) + if(!length(backlog) && !length(processing)) return if(!resumed)