Modular Tablets: Converting PDAs to the NtOS System (#65755)

Converts PDA functions and applications over to modular tablets and devices, namely the messaging function. HREF data code is quite honestly clunky and difficult to work with, as I've definitely experienced whilst working on this. By moving from this system over the easier to read (and frankly, easier to add to) TGUI system, you get cleaner looking and more user friendly UIs and a greater degree of standardization amongst other UIs.

Co-authored-by: Seth Scherer <supernovaa41@gmx.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>

code/modules/modular_computers/computers/item/computer_ui.dm

@@ -4,6 +4,8 @@
 
 // Operates TGUI
 /obj/item/modular_computer/ui_interact(mob/user, datum/tgui/ui)
+	if(issilicon(user)) // silicons have some issues regarding real_name
+		saved_identification = user.real_name
 	if(!enabled)
 		if(ui)
 			ui.close()
@@ -37,6 +39,10 @@
 		to_chat(user, span_danger("\The [src] beeps three times, it's screen displaying a \"DISK ERROR\" warning."))
 		return // No HDD, No HDD files list or no stored files. Something is very broken.
 
+	if(honkamnt > 0) // EXTRA annoying, huh!
+		honkamnt--
+		playsound(src, 'sound/items/bikehorn.ogg', 30, TRUE)
+
 	ui = SStgui.try_update_ui(user, src, ui)
 	if (!ui)
 		ui = new(user, src, "NtosMain")
@@ -44,28 +50,55 @@
 		if(ui.open())
 			ui.send_asset(get_asset_datum(/datum/asset/simple/headers))
 
+/obj/item/modular_computer/ui_static_data(mob/user)
+	. = ..()
+	var/list/data = list()
+
+	data["show_imprint"] = istype(src, /obj/item/modular_computer/tablet/)
+
+	return data
+
+
 
 /obj/item/modular_computer/ui_data(mob/user)
 	var/list/data = get_header_data()
 	data["device_theme"] = device_theme
-
 	data["login"] = list()
+
+	data["disk"] = null
+
 	var/obj/item/computer_hardware/card_slot/cardholder = all_components[MC_CARD]
+	var/obj/item/computer_hardware/hard_drive/role/ssd = all_components[MC_HDD_JOB]
 	data["cardholder"] = FALSE
+
 	if(cardholder)
 		data["cardholder"] = TRUE
-		var/obj/item/card/id/stored_card = cardholder.GetID()
-		if(stored_card)
-			var/stored_name = stored_card.registered_name
-			var/stored_title = stored_card.assignment
-			if(!stored_name)
-				stored_name = "Unknown"
-			if(!stored_title)
-				stored_title = "Unknown"
-			data["login"] = list(
-				IDName = stored_name,
-				IDJob = stored_title,
-			)
+
+		var/stored_name = saved_identification
+		var/stored_title = saved_job
+		if(!stored_name)
+			stored_name = "Unknown"
+		if(!stored_title)
+			stored_title = "Unknown"
+		data["login"] = list(
+			IDName = saved_identification,
+			IDJob = saved_job,
+		)
+		data["proposed_login"] = list(
+			IDName = cardholder.current_identification,
+			IDJob = cardholder.current_job,
+		)
+
+	if(ssd)
+		data["disk"] = ssd
+		data["disk_name"] = ssd.name
+
+		for(var/datum/computer_file/program/prog in ssd.stored_files)
+			var/running = FALSE
+			if(prog in idle_threads)
+				running = TRUE
+
+			data["disk_programs"] += list(list("name" = prog.filename, "desc" = prog.filedesc, "running" = running, "icon" = prog.program_icon, "alert" = prog.alert_pending))
 
 	data["removable_media"] = list()
 	if(all_components[MC_SDD])
@@ -89,6 +122,7 @@
 	data["has_light"] = has_light
 	data["light_on"] = light_on
 	data["comp_light_color"] = comp_light_color
+	data["pai"] = pai
 	return data
 
 
@@ -134,10 +168,15 @@
 
 		if("PC_runprogram")
 			var/prog = params["name"]
+			var/is_disk = params["is_disk"]
 			var/datum/computer_file/program/P = null
+			var/obj/item/computer_hardware/hard_drive/role/ssd = all_components[MC_HDD_JOB]
 			var/mob/user = usr
-			if(hard_drive)
+
+			if(hard_drive && !is_disk)
 				P = hard_drive.find_file_by_name(prog)
+			if(ssd && is_disk)
+				P = ssd.find_file_by_name(prog)
 
 			if(!P || !istype(P)) // Program not found or it's not executable program.
 				to_chat(user, span_danger("\The [src]'s screen shows \"I/O ERROR - Unable to run program\" warning."))
@@ -198,6 +237,13 @@
 					if(uninstall_component(portable_drive, usr))
 						user.put_in_hands(portable_drive)
 						playsound(src, 'sound/machines/card_slide.ogg', 50)
+				if("job disk")
+					var/obj/item/computer_hardware/hard_drive/role/ssd = all_components[MC_HDD_JOB]
+					if(!ssd)
+						return
+					if(uninstall_component(ssd, usr))
+						user.put_in_hands(ssd)
+						playsound(src, 'sound/machines/card_slide.ogg', 50)
 				if("intelliCard")
 					var/obj/item/computer_hardware/ai_slot/intelliholder = all_components[MC_AI]
 					if(!intelliholder)
@@ -208,14 +254,37 @@
 					var/obj/item/computer_hardware/card_slot/cardholder = all_components[MC_CARD]
 					if(!cardholder)
 						return
-					cardholder.try_eject(user)
+					if(cardholder.try_eject(user))
+						playsound(src, 'sound/machines/card_slide.ogg', 50)
 				if("secondary RFID card")
 					var/obj/item/computer_hardware/card_slot/cardholder = all_components[MC_CARD2]
 					if(!cardholder)
 						return
-					cardholder.try_eject(user)
+					if(cardholder.try_eject(user))
+						playsound(src, 'sound/machines/card_slide.ogg', 50)
+		if("PC_Imprint_ID")
+			var/obj/item/computer_hardware/card_slot/cardholder = all_components[MC_CARD]
+			var/obj/item/computer_hardware/identifier/id_hardware = all_components[MC_IDENTIFY]
+			if(!cardholder)
+				return
 
+			saved_identification = cardholder.current_identification
+			saved_job = cardholder.current_job
 
+			if(id_hardware)
+				id_hardware.UpdateDisplay()
+
+			playsound(src, 'sound/machines/terminal_processing.ogg', 15, TRUE)
+		if("PC_Pai_Interact")
+			switch(params["option"])
+				if("eject")
+					usr.put_in_hands(pai)
+					pai.slotted = FALSE
+					pai = null
+					to_chat(usr, span_notice("You remove the pAI from the [name]."))
+				if("interact")
+					pai.attack_self(usr)
+			return UI_UPDATE
 		else
 			return