From cd307db77d493e7a0eac33058282f0e6c6f7911a Mon Sep 17 00:00:00 2001
From: Roxy <75404941+TealSeer@users.noreply.github.com>
Date: Sun, 1 Jun 2025 15:47:54 -0400
Subject: [PATCH] Fix some DB issues and lag (#91420)

- ~~The DB schema version define was set to 5.30, the changelog readme
said the latest was 5.28, and the sample insert query in the readme said
it was 5.31~~ (fixed in #91127) Changes the define and readme to 5.32
- Add new entry in readme to rename `character` column in `manifest`
table to `character_name`, because `character` is a reserved word in SQL
and every insert query is failing
- Changed the initial roundstart manifest queries from
number_of_players_readied_up individual insert queries to one mass
insert because I suspect this is add several extra seconds to the start
time

fix yes :)
:cl:
server: increment DB schema version to 5.32
server: changed column name in manifest table from character to
character_name because the former is a reserved word
fix: changed round start manifest DB queries from dozens of individual
inserts to one mass insert
fix: hopefully fixed some lag on round start
/:cl:
---
 SQL/database_changelog.md | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/SQL/database_changelog.md b/SQL/database_changelog.md
index 5ef22486a28..def6732b205 100644
--- a/SQL/database_changelog.md
+++ b/SQL/database_changelog.md
@@ -2,7 +2,7 @@ Any time you make a change to the schema files, remember to increment the databa
 
 Make sure to also update `DB_MAJOR_VERSION` and `DB_MINOR_VERSION`, which can be found in `code/__DEFINES/subsystem.dm`.
 
-The latest database version is 5.34 (for bubberstation) (5.31 for /tg/); The query to update the schema revision table is:
+The latest database version is 5.34 (for bubberstation) (5.32 for /tg/); The query to update the schema revision table is:
 
 ```sql
 INSERT INTO `schema_revision` (`major`, `minor`) VALUES (5, 34);
@@ -18,6 +18,16 @@ In any query remember to add a prefix to the table names if you use one.
 
 ---
 
+Version 5.32, 31 May 2025, by TealSeer
+Change column name of `manifest` table because `character` is a reserved word.
+
+```sql
+ALTER TABLE `manifest`
+	RENAME COLUMN `character` TO `character_name`;
+```
+
+---
+
 Version 5.31, 3 May 2025, by Atlanta-Ned
 Adds a `manifest` table.