From cec80b3e8a05867f75a8cf932a3d97de8f8b18e4 Mon Sep 17 00:00:00 2001 From: SmArtKar <44720187+SmArtKar@users.noreply.github.com> Date: Sun, 5 Oct 2025 22:35:16 +0200 Subject: [PATCH] [NO GBP] Fixes ore bags only picking one item per holder's move (#93278) ## About The Pull Request Small oversight, ``||=`` ends up not running if show_message is TRUE, so it only picks up one item at a time per move --- code/game/objects/items/storage/bags.dm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/code/game/objects/items/storage/bags.dm b/code/game/objects/items/storage/bags.dm index b9da9b34bb3..0d26a27bbd8 100644 --- a/code/game/objects/items/storage/bags.dm +++ b/code/game/objects/items/storage/bags.dm @@ -164,8 +164,10 @@ var/show_message = FALSE for(var/atom/thing as anything in tile) - if(is_type_in_typecache(thing, atom_storage.can_hold)) - show_message ||= pickup_ore(thing, user, box) + if(!is_type_in_typecache(thing, atom_storage.can_hold)) + continue + if(pickup_ore(thing, user, box)) + show_message = TRUE if (!show_message) spam_protection = FALSE