mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-24 05:30:05 +01:00
Converts 3 components into elements (#94589)
## About The Pull Request `adjust_fishing_difficulty` is a good one to make into a bespoke element since a number of the same clothing item are created in the wardrobe system. climb_walkable is also good due to how prevalent it is, and it is a bit of a two for one since it also removes the need for the `/component/connect_loc_behalf` Also stops adding the on_climbable trait to literally everything in the turf, it now only applies it to atoms with density. So no more pipes and stuff getting trait lists created for no reason. <details><summary> Tested + things still work as before </summary> <img width="422" height="122" alt="image" src="https://github.com/user-attachments/assets/b23696f5-cd16-4150-aeb3-14ea6bd256fc" /> </details> ## Why It's Good For The Game Lessens overhead, fixes a bug as well. ## Changelog 🆑 fix: fixes a pushed crate not removing on_climbable trait properly off the mob standing atop it /🆑
This commit is contained in:
@@ -1008,14 +1008,14 @@
|
||||
var/obj/item/gloves = mod.get_part_from_slot(ITEM_SLOT_GLOVES)
|
||||
if(!gloves)
|
||||
return
|
||||
gloves.AddComponent(/datum/component/adjust_fishing_difficulty, -5)
|
||||
gloves.AddElement(/datum/element/adjust_fishing_difficulty, -5)
|
||||
if(equipped)
|
||||
gloves.AddComponent(/datum/component/profound_fisher, equipped, delete_rod_when_deleted = FALSE)
|
||||
|
||||
/obj/item/mod/module/fishing_glove/on_part_deactivation(deleting = FALSE)
|
||||
var/obj/item/gloves = mod.get_part_from_slot(ITEM_SLOT_GLOVES)
|
||||
if(gloves && !deleting)
|
||||
qdel(gloves.GetComponent(/datum/component/adjust_fishing_difficulty))
|
||||
gloves.RemoveElement(/datum/element/adjust_fishing_difficulty)
|
||||
qdel(gloves.GetComponent(/datum/component/profound_fisher))
|
||||
|
||||
/obj/item/mod/module/shock_absorber
|
||||
|
||||
Reference in New Issue
Block a user