cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-23 21:18:37 +01:00
Code Issues Packages Projects Releases Wiki Activity

fixes basic mobs with ranged attacks attacking in containers (#81804)

Browse Source 
## About The Pull Request
see title - changes an isturf check to an !ismob check for an attacking
basic mob's loc in can_attack(), as previously this allowed mobs to
shoot from inside containers

## Why It's Good For The Game

![image](https://github.com/tgstation/tgstation/assets/31829017/ffe03955-78f2-4e6e-b15c-9fdf6d85d588)
## Changelog

🆑
fix: Basic mobs no longer have the (unintended) ability to shoot out of
containers, like bluespace body bags.
/🆑

---------

Co-authored-by: Hatterhat <Hatterhat@users.noreply.github.com>
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
This commit is contained in:
Hatterhat
2024-03-06 18:58:13 +01:00
committed by GitHub
co-authored by Hatterhat Ghom
parent cd6399f7a7
commit cfc9dbf437
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/datums/ai/basic_mobs/targeting_strategies/basic_targeting_strategy.dm
+3 -1
View File
@@ -50,7 +50,9 @@
if(living_mob.see_invisible < the_target.invisibility) //Target's invisible to us, forget it
return FALSE
if(isturf(living_mob.loc) && isturf(the_target.loc) && living_mob.z != the_target.z) // z check will always fail if target is in a mech or pawn is shapeshifted or jaunting
if(!isturf(living_mob.loc))
return FALSE
if(isturf(the_target.loc) && living_mob.z != the_target.z) // z check will always fail if target is in a mech or pawn is shapeshifted or jaunting
return FALSE
if(isliving(the_target)) //Targeting vs living mobs