From d01ee3e7a6cbde2d07cfeb1882a51556fcb457cb Mon Sep 17 00:00:00 2001 From: SkyratBot <59378654+SkyratBot@users.noreply.github.com> Date: Thu, 19 Jan 2023 22:11:23 +0100 Subject: [PATCH] [MIRROR] Fiox firebots extinguishing themselves while also not on fire (fixes #71390) [MDB IGNORE] (#18825) Fiox firebots extinguishing themselves while also not on fire (fixes #71390) (#72707) Firebots returned themselves if they found themselves in the `process_scan()` override. The override usually checks to see if the found target is on fire, to then extinguish it. This leads to the firebots attempting to constantly extinguish themselves. I'm not sure why this behaviour was here, as the other bots don't seem to return themselves in their `process_scan()` overrides. If someone has any insights on why this should be here and I should fix it differently, go ahead. The only alternative I see right now would be to return `null` on finding that the current scan object is `src`, which would shorten the program path a little. Co-authored-by: Inari-Whitebear --- code/modules/mob/living/simple_animal/bot/firebot.dm | 2 -- 1 file changed, 2 deletions(-) diff --git a/code/modules/mob/living/simple_animal/bot/firebot.dm b/code/modules/mob/living/simple_animal/bot/firebot.dm index 650b28fcb63..64aafb8071b 100644 --- a/code/modules/mob/living/simple_animal/bot/firebot.dm +++ b/code/modules/mob/living/simple_animal/bot/firebot.dm @@ -253,8 +253,6 @@ //Look for burning people or turfs around the bot /mob/living/simple_animal/bot/firebot/process_scan(atom/scan_target) - if(scan_target == src) - return src if(!is_burning(scan_target)) return null