From d0df1a875cbd50f9cbcfc25d194d348c0d4ed5da Mon Sep 17 00:00:00 2001
From: skoglol <33292112+kriskog@users.noreply.github.com>
Date: Mon, 20 Jul 2020 23:16:37 +0200
Subject: [PATCH] Some buildmode additions, fixes (#52249)

* Adds outfit buildmode mode

* Adds a delete mode, makes copy compatible with humans

* comment fix

* AIstatus

* Tick the files, dummy

* none of that

* Some more copy restrictions

* Apply suggestions from code review

Co-authored-by: Rohesie <rohesie@gmail.com>

* Apply suggestions from code review

Co-authored-by: Rohesie <rohesie@gmail.com>

Co-authored-by: Rohesie <rohesie@gmail.com>
---
 code/modules/buildmode/buildmode.dm       |   8 +--
 code/modules/buildmode/submodes/delete.dm |  62 ++++++++++++++++++++++
 code/modules/buildmode/submodes/outfit.dm |  44 +++++++++++++++
 code/modules/holodeck/area_copy.dm        |  12 ++++-
 icons/misc/buildmode.dmi                  | Bin 1711 -> 1818 bytes
 tgstation.dme                             |   2 +
 6 files changed, 122 insertions(+), 6 deletions(-)
 create mode 100644 code/modules/buildmode/submodes/delete.dm
 create mode 100644 code/modules/buildmode/submodes/outfit.dm

diff --git a/code/modules/buildmode/buildmode.dm b/code/modules/buildmode/buildmode.dm
index 4a56257882a..735c2a4c045 100644
--- a/code/modules/buildmode/buildmode.dm
+++ b/code/modules/buildmode/buildmode.dm
@@ -34,7 +34,7 @@
 	holder.screen += buttons
 	holder.click_intercept = src
 	mode.enter_mode(src)
-	
+
 /datum/buildmode/proc/quit()
 	mode.exit_mode(src)
 	holder.screen -= buttons
@@ -100,7 +100,7 @@
 	else
 		close_switchstates()
 		open_modeswitch()
-	
+
 /datum/buildmode/proc/open_modeswitch()
 	switch_state = BM_SWITCHSTATE_MODE
 	holder.screen += modeswitch_buttons
@@ -115,7 +115,7 @@
 	else
 		close_switchstates()
 		open_dirswitch()
-	
+
 /datum/buildmode/proc/open_dirswitch()
 	switch_state = BM_SWITCHSTATE_DIR
 	holder.screen += dirswitch_buttons
@@ -155,7 +155,7 @@
 			new /datum/buildmode(M.client)
 			message_admins("[key_name_admin(usr)] has entered build mode.")
 			log_admin("[key_name(usr)] has entered build mode.")
-	
+
 #undef BM_SWITCHSTATE_NONE
 #undef BM_SWITCHSTATE_MODE
 #undef BM_SWITCHSTATE_DIR
diff --git a/code/modules/buildmode/submodes/delete.dm b/code/modules/buildmode/submodes/delete.dm
new file mode 100644
index 00000000000..ea2145a8dbd
--- /dev/null
+++ b/code/modules/buildmode/submodes/delete.dm
@@ -0,0 +1,62 @@
+/datum/buildmode_mode/delete
+	key = "delete"
+
+/datum/buildmode_mode/delete/show_help(client/c)
+	to_chat(c, "<span class='notice'>***********************************************************\n\
+		Left Mouse Button on anything to delete it. If you break it, you buy it.\n\
+		Right Mouse Button on anything to delete everything of the type. Probably don\'t do this unless you know what you are doing.\n\
+		***********************************************************</span>")
+
+/datum/buildmode_mode/delete/handle_click(client/c, params, object)
+	var/list/pa = params2list(params)
+	var/left_click = pa.Find("left")
+	var/right_click = pa.Find("right")
+
+	if(left_click)
+		if(isturf(object))
+			var/turf/T = object
+			T.ScrapeAway(flags = CHANGETURF_INHERIT_AIR)
+		else if(isatom(object))
+			qdel(object)
+
+	if(right_click)
+		if(check_rights(R_DEBUG|R_SERVER))	//Prevents buildmoded non-admins from breaking everything.
+			if(isturf(object))
+				return
+			var/atom/deleting = object
+			var/action_type = alert("Strict type ([deleting.type]) or type and all subtypes?",,"Strict type","Type and subtypes","Cancel")
+			if(action_type == "Cancel" || !action_type)
+				return
+
+			if(alert("Are you really sure you want to delete all instances of type [deleting.type]?",,"Yes","No") != "Yes")
+				return
+
+			if(alert("Second confirmation required. Delete?",,"Yes","No") != "Yes")
+				return
+
+			var/O_type = deleting.type
+			switch(action_type)
+				if("Strict type")
+					var/i = 0
+					for(var/atom/Obj in world)
+						if(Obj.type == O_type)
+							i++
+							qdel(Obj)
+						CHECK_TICK
+					if(!i)
+						to_chat(usr, "No instances of this type exist")
+						return
+					log_admin("[key_name(usr)] deleted all instances of type [O_type] ([i] instances deleted) ")
+					message_admins("<span class='notice'>[key_name(usr)] deleted all instances of type [O_type] ([i] instances deleted) </span>")
+				if("Type and subtypes")
+					var/i = 0
+					for(var/Obj in world)
+						if(istype(Obj,O_type))
+							i++
+							qdel(Obj)
+						CHECK_TICK
+					if(!i)
+						to_chat(usr, "No instances of this type exist")
+						return
+					log_admin("[key_name(usr)] deleted all instances of type or subtype of [O_type] ([i] instances deleted) ")
+					message_admins("<span class='notice'>[key_name(usr)] deleted all instances of type or subtype of [O_type] ([i] instances deleted) </span>")
diff --git a/code/modules/buildmode/submodes/outfit.dm b/code/modules/buildmode/submodes/outfit.dm
new file mode 100644
index 00000000000..55ca0f4464d
--- /dev/null
+++ b/code/modules/buildmode/submodes/outfit.dm
@@ -0,0 +1,44 @@
+/datum/buildmode_mode/outfit
+	key = "outfit"
+	var/datum/outfit/dressuptime
+
+/datum/buildmode_mode/outfit/Destroy()
+	dressuptime = null
+	return ..()
+
+/datum/buildmode_mode/outfit/show_help(client/c)
+	to_chat(c, "<span class='notice'>***********************************************************\n\
+		Right Mouse Button on buildmode button = Select outfit to equip.\n\
+		Left Mouse Button on mob/living/carbon/human = Equip the selected outfit.\n\
+		Right Mouse Button on mob/living/carbon/human = Strip and delete current outfit.\n\
+		***********************************************************</span>")
+
+/datum/buildmode_mode/outfit/Reset()
+	. = ..()
+	dressuptime = null
+
+/datum/buildmode_mode/outfit/change_settings(client/c)
+	dressuptime = c.robust_dress_shop()
+
+/datum/buildmode_mode/outfit/handle_click(client/c, params, object)
+	var/list/pa = params2list(params)
+	var/left_click = pa.Find("left")
+	var/right_click = pa.Find("right")
+
+	if(!ishuman(object))
+		return
+	var/mob/living/carbon/human/dollie = object
+
+	if(left_click)
+		if(isnull(dressuptime))
+			to_chat(c, "<span class='warning'>Pick an outfit first.</span>")
+			return
+
+		for (var/item in dollie.get_equipped_items(TRUE))
+			qdel(item)
+		if(dressuptime != "Naked")
+			dollie.equipOutfit(dressuptime)
+
+	if(right_click)
+		for (var/item in dollie.get_equipped_items(TRUE))
+			qdel(item)
diff --git a/code/modules/holodeck/area_copy.dm b/code/modules/holodeck/area_copy.dm
index 46a0fd38a6c..19a2615b731 100644
--- a/code/modules/holodeck/area_copy.dm
+++ b/code/modules/holodeck/area_copy.dm
@@ -1,7 +1,10 @@
 //Vars that will not be copied when using /DuplicateObject
 GLOBAL_LIST_INIT(duplicate_forbidden_vars,list(
 	"tag", "datum_components", "area", "type", "loc", "locs", "vars", "parent", "parent_type", "verbs", "ckey", "key",
-	"power_supply", "contents", "reagents", "stat", "x", "y", "z", "group", "atmos_adjacent_turfs", "comp_lookup"
+	"power_supply", "contents", "reagents", "stat", "x", "y", "z", "group", "atmos_adjacent_turfs", "comp_lookup",
+	"client_mobs_in_contents", "bodyparts", "internal_organs", "hand_bodyparts", "overlays", "overlays_standing", "hud_list",
+	"actions", "AIStatus", "appearance", "managed_overlays", "managed_vis_overlays", "computer_id", "lastKnownIP", "implants",
+	"tgui_shared_states"
 	))
 
 /proc/DuplicateObject(atom/original, perfectcopy = TRUE, sameloc, atom/newloc = null, nerf, holoitem)
@@ -20,7 +23,7 @@ GLOBAL_LIST_INIT(duplicate_forbidden_vars,list(
 			if(islist(original.vars[V]))
 				var/list/L = original.vars[V]
 				O.vars[V] = L.Copy()
-			else if(istype(original.vars[V], /datum))
+			else if(istype(original.vars[V], /datum) || ismob(original.vars[V]))
 				continue	// this would reference the original's object, that will break when it is used or deleted.
 			else
 				O.vars[V] = original.vars[V]
@@ -52,6 +55,11 @@ GLOBAL_LIST_INIT(duplicate_forbidden_vars,list(
 				contained_atom.flags_1 |= HOLOGRAM_1
 			if(M.circuit)
 				M.circuit.flags_1 |= HOLOGRAM_1
+
+	if(ismob(O))	//Overlays are carried over despite disallowing them, if a fix is found remove this.
+		var/mob/M = O
+		M.cut_overlays()
+		M.regenerate_icons()
 	return O
 
 
diff --git a/icons/misc/buildmode.dmi b/icons/misc/buildmode.dmi
index f0de428b6c55b37d8ad59cac0e9e5064e2d64ad7..fb51ad68116039b29ec6659190f15789f8b805c9 100644
GIT binary patch
delta 1727
zcmV;w20;0*4Vn&+UIF8gUlo79Zo)7ShiCgKEZ9+L8M?4kK@~%Jh02L9@u_w$wJ$-u
zJ)sN;l%U$%{iN^H{jt1MAG^=}K^0$nIY5X=t=g*1>P3np8n$D2dzHchHkPj;vSt{|
zMcJb>3n>hSIOcaL>YzPb>h%L<!F4xseMbsM)J-^^41AY5VwGiTGw6S|0+S_!LCzA{
z20CV$UUv<&bLzeD+h>kfQFr=Zi|Y*o=x3*xP-=880e9H`B;X~HPr#!dAZ1<l6cc#r
zxz2nD0}gn0wwt<CyF>B!JI^t*7W6C;i=+Sm1-MB>K~!jg?V3%p)H)1>!wz^2)MMJr
z7_tPaQsprd-U?p40b_rS**TVE*_QKTCoxn})#(fLq0{NFW!XAb?)2s#b-cZ+r^hFC
zJn!o1@hm^!@w}_2$Gf>WzC7>h>G9$Fl8*nsJ)^c>>-zOdTL8~`db}?`;p;PM0IloS
zwFWoO21p0Or8w{tm;8xI*RN}BS$NcYgvOm9<a1|pKp11#M`(ZLd_RcLi85mdZ9d-*
zAv9UKafATl2=PpypV^!ww5+{8-^WD6fBOjy;Nd7{{4^69WAJ?ETtQe9tu$Q)Q1i3=
zy0_Ni`QH12uobfwArA2&;pV9B#&7}pSxykP@{m_2carcR5Bc!p2>JbE2y;yBGK3J<
zL4LoR#}EplEmnVQ6BFwa;T+c+7gubmV!T>(SGh{#ys@CF-klh#Zx{-F851nr_w;YD
zBBRaHa69+%hok&q_IG`n*5}QcGu8gCO9!zxv!>eL^=O>>kX9Qkc-8_{zDQX5yB>|S
zd36dk&(Tl#UnW%ku0zx6Vj&TRiX8p~LK|y}@^>AY!%2ULT&IOF))ejU+BynC+$7Zg
zuB}DLs0T0|L+$U{I_6v^gz&1xM;vAC@7h`bC5Ed!)c&rm3&4#kIMx2HtqZ^%Lgnw;
zx&V}!LaB+5OgPV)=s<Hy=DCco27XM#6vM*bwe^zoQu2@<R(4X_-?jCM5as|0E)i;f
z*VY?^A;^C?RZ7C-@7j7rI6L$WnNa(?4qX!hhOiiA?e99Y%Dc@KyYzQGx||ssGe!Hm
z9z7qpwW;=ZUHYJFvg2S|`Y47kfB47!;ZLnUzWm{C|M0Tj>x!JvCVQXgZIr*eu%ic2
zaXr-j?gBB0e@xz{bWa!d%Yq0}Q<T5E5>rM**LZ)CF!(G0GGx&&LIjkm=T64Zx%iIl
zF0uA^6qE2Q)G+XI6a#-aCwQCq4Z;&eNQktN+0H{^HMxc$O*~{*K!n9N2)+U4IaR%S
z)G(Sh?@PQ5xQLYqIqF4>bKje*o|_R#Vq$;;v`e@V<J6hwx@<!PY^u9!LW&wX7#UTx
z3ATUCg0!>ZofO&=<6tL-D<U?8dheIJA|H^4V&WGy%H`fp=V5pQ;5&-FpBK*^y^V9c
zd+Y5aIdWU&-cNP~aj)lb_ZCcQ-%OzxmW1Lg3PQloy|~)&B#GZ}uaA97a}HWKx}S1J
zGaw<3Aq4S{FosY75%KGYs`p>^;6KL1Q0ae{KOA7^>J#qj-{22FmmhFpP^$O;E&dR1
zGYy+5(#y(y81xaI{<^UG6#c{G1e~FwVY>FmTZFNxkZJ@LU@u*cuKOw0ru%$l|4^zP
zfB}bYrI%2gju3KZ2p~HJL_9$Viz1AD85-yuLxBDmR)o}IjrTjRRXqy2CgdBaSL=Ur
zHOe;Kn+2cpaJi9(M()kVyR+PAJ91xbLXabNl4w(q+!w+6#qJV@uM!3t9j4@Ax}fBt
zcCgYP+#O|_S|&J5$-`qpzr_CF;V5JFT5(@1LO|1;XO1Rxc(a12(oTvA({B-YO;{7u
zgrotdQ$?8WfE!I%$B2k%f)_CbV^V(>0PP}NCam(Xm3K^xMtpBQtn#pxcRcD~%<hVv
z60y?{QeN8a)hKu8=yw-}%;oP1acEbB>)y*BUNK9<?cC~wf3<ElAnW7yS6p52raxR?
z@U9<RUGVPASY7b$%vclZ)#7v=?jXb)OlVh3*Zq?YLQj1h?>ATE*wMtb$@hN}LTn}N
z5SrPu-F16};MauI^sw863)k#@LRS&WA%uAAG1NR0`-|~L;{l<kh(XzHQ$%EFZF02e
zg^me<J8ye=XAJd`oj3(Ut)(ME>?@rk3|Sz(vCUCFCZvdQ6S<QRJZE0#OlimP)ZFbE
z<&$%{ork9hU1O%4C6u{LesVJaq1FQkwSE!)6;<!9A6#AVt{+@oaI{%!`MtAt?iUza
VX(MfGvSt7P002ovPDHLkV1fa2Wdi^J

delta 1619
zcmV-Z2CVs-4zCT6UIEmRUlo7L3c@fDMc2t!1iKes3pZ{=5f}CsByFb6VA82c+T!0^
zbs>t1&2BE7!#rRTvEJ_Xsn{I$yanfxDzOra@r1JuRnUEy&p6Y7r4EnagACA@qpU%r
zMw}^hzRyd}3MVbx>ggM$!PHN3`a&{8RDW<RDL7`*V;*Hn)ygUd6(xUz!Vo0}?Wl_~
zt*lF^zNxRmxrrPvr~2|=i^mNe$X}=UpcH7#0Nh}88h~d+b^z{W3q#fomi#w95!-Zg
z|C1}?8}of4(fOqS00mr0L_t(&f$f@4vfDNc#?>3NZZpl+-F4X`WJWVwcaxqV;ssb@
z-J6#H2$G=wkd*m4>5PBnm&9Kz%Rhr4@ez8<4?n5n$5-|8_)Q(pSM~CEmLKqVzN(kU
z&uek~@qAS;k56B>bbR~s8MXCV*RNOF0(jQT<CpRizC5D_(7JwIYjEpofOH_-iUU7!
z%b%EZ{kqncg-3lxXxsoHpSzk1!WhFoLM!L{NrX<6nL}vv`F?*2p~=$CBLtX7h-U)*
ztY(nVviACX9}^M(?I$#VhohMB(@bcL!SkJS1z}CJ({vR;&Cl}d-dc<2d+!UvR?J$2
zIK-EPhogEL!wu+X8z5}uA+Jtuknkc8`S9}y`TcVUb4=|vg%H<4e!pAi5DKC#R%{a!
z>lWb}*BcjCY^r}^yjpZuxk}@_v7oBnD=}2xFckVSCRn&%(;r|(W}BtycJA#DXZgeI
z@A@>Y&xbQ-sr_A-4&rQPEw#Vv(Kz)Xtu|QjtOcrkk+Af4JsN5A>J)08qo44<OsM=_
zho;rVLLv+mIs6HPHr5p7?>aPxlMuO13t_A&+TXQx6oh|xNT~f?TZ@oU4`4cm+TXQx
z%(+Ym;Z=)|ILg}JwY30B40m~`{asrZfCp7@sr_AB7l0>(%HOqh0Vp$tQWGDUa9uUg
zh31sZa~WR^{FsI*hK0Xt>n-P{<RLw*?4-26YwH~$tN{{SBGmq_tq%x8ka4P%gvsBv
z^^S0L=o^1Bq4swjx+Vk+VKK_u-*sq}cZVx>>F;`UIWrDsiuQLsdcAOKOYQHv^hMX?
z#KE@oRSe($@IUv5|7iXB?GI1;hqv`vS7bn&?0urQQU316jvhqC^-%k}8^j>~F?pNP
zJ>A$Z3nEBOQU2~uOc@bf<4wZgvjE7DMZX9UP^y2P8;qfI@g2uqV(srJCgEAAVc_E^
z2L5nP@HX)qgeQuS5NRWGoQK3}at%S6c*w4R2#aqJd;_d&s(SUPVKi;tmv|d+5i1dL
z)QcGBzBgArw<40n!~h5Al<*+NsWZ=Y*@g(%RCo7;6g6}(GOB13Y?%dVXT>`yv?s>F
zNeq8?L~IE4-Y<7WJ|Pdq#BXYp%e|e>!|(>ccNBX+FP=Mk8|QfU*4s&P<hIJapX>_a
zUeDw1Etu54nL;rv3B_3ygn*xWbG6|~62IYDAA3l14qCXnpE9BukPzn(g7`<6LnwfV
z_+>`b`zw3!zvskI>9;?eVCU)+UezDq4}X6zKj6loRPX=4_(QzSG;O9xFDv(9&_{Us
z>&EI+^beC0aE6M8>DnJ35yqxMsu5U#y>vOc?x$Fr?(>!XL#cWI1{}JTUP5s?LdcyV
zfb0|yaexpuMHu@sG|)MQ0R1tn2&u&y?|0s-dK7d`$Tv{$*5zuHZMruLKIP%|LLPq_
zxi=f{&T^ye%6+v7L5|o-qD?_^Uj*wndrBC-N*HK#n39L-f|7^Y!AgJdbd+goncy%b
z53dRR7W;#jqm0>W#eMAv0ZntBIhxSn%?hGQJ1HhizeV6RVNFmIk_Mbk6=AvqZZu&X
zBO;;+Uc?lPNm&52i*T8+%EMOPF)@D{@w4@?%EMOP@u-6_rz>_!#7;j*d1;SVquiaN
z-(8q8m%k>&sa+ASdvAYu$1F{^bGs9Mtxgy{nqOh~f(?H-e!-UC8@^yG^M^0k%KUM{
z-D;v&j|qf$g9+`5agzu=^>I9RNoEj2Y$e?$1ivSwriZ;r=qf@vZWDTn82CqNqYT`6
zo0x}wGT}O#5Ikqzhs~7le=ffX--K<#@4o7_{NC^dTYhi&g0sz1)9(!){{juuWYX^o
RZT$cM002ovPDHLkV1hj>D5L-Y

diff --git a/tgstation.dme b/tgstation.dme
index 891ffcaa6f8..87181078c6e 100644
--- a/tgstation.dme
+++ b/tgstation.dme
@@ -1643,8 +1643,10 @@
 #include "code\modules\buildmode\submodes\basic.dm"
 #include "code\modules\buildmode\submodes\boom.dm"
 #include "code\modules\buildmode\submodes\copy.dm"
+#include "code\modules\buildmode\submodes\delete.dm"
 #include "code\modules\buildmode\submodes\fill.dm"
 #include "code\modules\buildmode\submodes\mapgen.dm"
+#include "code\modules\buildmode\submodes\outfit.dm"
 #include "code\modules\buildmode\submodes\throwing.dm"
 #include "code\modules\buildmode\submodes\variable_edit.dm"
 #include "code\modules\cargo\bounty.dm"