mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-07-20 20:45:28 +01:00
Increases logging for candidate polls (#91590)
## About The Pull Request The game will now log when someone signs up or removes their candidacy for ghost polls for roles. This also fixes a runtime I experienced while testing it and running pirates with no candidates signed up, IDK if it had any effect but it's possible the runtime was causing the ship not to spawn. ## Why It's Good For The Game Mostly just that I saw admins requesting this on several recent occasions. It's already possible to dig up some of this information through the existing logs but it's a bit of a pain. ## Changelog 🆑 admin: Additional logging for when people sign up for ghost roles. /🆑
This commit is contained in:
@@ -63,7 +63,11 @@ SUBSYSTEM_DEF(polling)
|
||||
question = "Do you want to play as [span_notice(role_name_text)]?"
|
||||
if(!question)
|
||||
question = "Do you want to play as a special role?"
|
||||
log_game("Polling candidates [role_name_text ? "for [role_name_text]" : "\"[question]\""] for [DisplayTimeText(poll_time)] seconds")
|
||||
log_ghost_poll("Candidate poll started.", data = list(
|
||||
"role name" = role_name_text,
|
||||
"poll question" = question,
|
||||
"poll duration" = DisplayTimeText(poll_time),
|
||||
))
|
||||
|
||||
// Start firing
|
||||
total_polls++
|
||||
@@ -302,7 +306,14 @@ SUBSYSTEM_DEF(polling)
|
||||
// Trim players who aren't eligible anymore
|
||||
var/length_pre_trim = length(finishing_poll.signed_up)
|
||||
finishing_poll.trim_candidates()
|
||||
log_game("Candidate poll [finishing_poll.role ? "for [finishing_poll.role]" : "\"[finishing_poll.question]\""] finished. [length_pre_trim] players signed up, [length(finishing_poll.signed_up)] after trimming")
|
||||
|
||||
log_ghost_poll("Candidate poll completed.", data = list(
|
||||
"role name" = finishing_poll.role,
|
||||
"poll question" = finishing_poll.question,
|
||||
"signed up count" = length_pre_trim,
|
||||
"trimmed candidate count" = length(finishing_poll.signed_up)
|
||||
))
|
||||
|
||||
finishing_poll.finished = TRUE
|
||||
|
||||
// Take care of updating the remaining screen alerts if a similar poll is found, or deleting them.
|
||||
|
||||
Reference in New Issue
Block a user