Fixed lights stopping emitting light in some situations (#84299)

## About The Pull Request

closes #77789
edt: also closes #82600

Light sources stop emitting light if the tile in which the light source
itself is located and all 4 adjacent tile block the light. This usually
happens when a smoke grenade is thrown, or something went wrong in the
chemistry again

<details>
<summary>Videos</summary>

As it was before


https://github.com/tgstation/tgstation/assets/112967882/44ff556b-d09f-4024-945e-c2c105f511a9

Now


https://github.com/tgstation/tgstation/assets/112967882/9f9f8f43-47a9-47be-8499-99bab39fc166


</details>

## Why It's Good For The Game

You wont need to switch the lights twice to make them work after someone
threw smoke grenades into the hallways anymore

## Changelog
🆑
fix: Fixed lights stopping emitting light in some situations
/🆑

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
This commit is contained in:
Kocma-san
2024-07-10 02:32:03 +07:00
committed by GitHub
parent efd5adfdd4
commit d1799dc6b5
3 changed files with 8 additions and 0 deletions

View File

@@ -96,6 +96,7 @@
//yes, we register the signal to the top atom too, this is intentional and ensures contained lighting updates properly
if(ismovable(new_atom_host))
RegisterSignal(new_atom_host, COMSIG_MOVABLE_MOVED, PROC_REF(update_host_lights))
RegisterSignal(new_atom_host, COMSIG_TURF_NO_LONGER_BLOCK_LIGHT, PROC_REF(force_update))
return TRUE
///remove this light source from old_atom_host's light_sources list, unsetting movement registrations
@@ -106,6 +107,7 @@
LAZYREMOVE(old_atom_host.light_sources, src)
if(ismovable(old_atom_host))
UnregisterSignal(old_atom_host, COMSIG_MOVABLE_MOVED)
UnregisterSignal(old_atom_host, COMSIG_TURF_NO_LONGER_BLOCK_LIGHT)
return TRUE
// Yes this doesn't align correctly on anything other than 4 width tabs.