cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-21 20:20:33 +01:00
Code Issues Packages Projects Releases Wiki Activity

[NO GBP] Renames mob/camera to mob/eye and makes everything follow suit (#87684)

Browse Source 
## Why It's Good For The Game

Clarity and consistency regarding DM's systems. 
Internally, `eye` is used for anything that controls the client's view.

![image](https://github.com/user-attachments/assets/7d1291e1-7a6a-4736-a14b-97834e89846f)
How `eye` is used in DM is consistent with how we use the term, so I
figured this would add clarity.

Being named mob/camera also makes it unclear exactly what it's doing.
The name implies that it would function similar to how mob/camera/ai_eye
does, but most of the time it's only used as... an eye.

My ulterior reason for this PR is that I want to clean up
mob/camera/ai_eye and it's subtypes after this.
## Changelog

🆑
server: mob/camera has been renamed to mob/eye, which may break
downstreams
/🆑

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
This commit is contained in:
tonty
2024-11-09 10:57:45 +00:00
committed by GitHub
co-authored by Ghom
parent bf2a1b7887
commit d5daa9c9b8
76 changed files with 298 additions and 298 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/datums/components/blob_minion.dm
+5 -5
View File
@@ -4,23 +4,23 @@
/datum/component/blob_minion
dupe_mode = COMPONENT_DUPE_UNIQUE_PASSARGS
/// Overmind who is our boss
var/mob/camera/blob/overmind
var/mob/eye/blob/overmind
/// Callback to run if overmind strain changes
var/datum/callback/on_strain_changed
/datum/component/blob_minion/Initialize(mob/camera/blob/overmind, datum/callback/on_strain_changed)
/datum/component/blob_minion/Initialize(mob/eye/blob/overmind, datum/callback/on_strain_changed)
. = ..()
if (!isliving(parent))
return COMPONENT_INCOMPATIBLE
src.on_strain_changed = on_strain_changed
register_overlord(overmind)
/datum/component/blob_minion/InheritComponent(datum/component/new_comp, i_am_original, mob/camera/blob/overmind, datum/callback/on_strain_changed)
/datum/component/blob_minion/InheritComponent(datum/component/new_comp, i_am_original, mob/eye/blob/overmind, datum/callback/on_strain_changed)
if (!isnull(on_strain_changed))
src.on_strain_changed = on_strain_changed
register_overlord(overmind)
/datum/component/blob_minion/proc/register_overlord(mob/camera/blob/overmind)
/datum/component/blob_minion/proc/register_overlord(mob/eye/blob/overmind)
if (isnull(overmind))
return
src.overmind = overmind
@@ -36,7 +36,7 @@
overmind_properties_changed()
/// Our overmind has changed colour and properties
/datum/component/blob_minion/proc/overmind_properties_changed(mob/camera/blob/overmind, datum/blobstrain/new_strain)
/datum/component/blob_minion/proc/overmind_properties_changed(mob/eye/blob/overmind, datum/blobstrain/new_strain)
SIGNAL_HANDLER
var/mob/living/living_parent = parent
living_parent.update_appearance(UPDATE_ICON)
code/datums/components/lock_on_cursor.dm
+1 -1
View File
@@ -36,7 +36,7 @@
lock_amount = 1,
list/target_typecache = list(),
list/immune = list(),
icon = 'icons/mob/silicon/cameramob.dmi',
icon = 'icons/mob/eyemob.dmi',
icon_state = "marker",
datum/callback/on_lock,
datum/callback/can_target_callback,