[NO GBP] Renames mob/camera to mob/eye and makes everything follow suit (#87684)

## Why It's Good For The Game

Clarity and consistency regarding DM's systems. 
Internally, `eye` is used for anything that controls the client's view.

![image](https://github.com/user-attachments/assets/7d1291e1-7a6a-4736-a14b-97834e89846f)
How `eye` is used in DM is consistent with how we use the term, so I
figured this would add clarity.

Being named mob/camera also makes it unclear exactly what it's doing.
The name implies that it would function similar to how mob/camera/ai_eye
does, but most of the time it's only used as... an eye.

My ulterior reason for this PR is that I want to clean up
mob/camera/ai_eye and it's subtypes after this.
## Changelog

🆑
server: mob/camera has been renamed to mob/eye, which may break
downstreams
/🆑

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
This commit is contained in:
tonty
2024-11-09 05:57:45 -05:00
committed by GitHub
parent bf2a1b7887
commit d5daa9c9b8
76 changed files with 298 additions and 298 deletions
@@ -5,7 +5,7 @@
/datum/action/innate/construction
button_icon = 'icons/mob/actions/actions_construction.dmi'
///Console's eye mob
var/mob/camera/ai_eye/remote/base_construction/remote_eye
var/mob/eye/ai_eye/remote/base_construction/remote_eye
///Console itself
var/obj/machinery/computer/camera_advanced/base_construction/base_console
///Is this used to build only on the station z level?
@@ -1,7 +1,7 @@
/**
* Camera console used to control a base building drone
*
* Using this console will put the user in control of a [base building drone][/mob/camera/ai_eye/remote/base_construction].
* Using this console will put the user in control of a [base building drone][/mob/eye/ai_eye/remote/base_construction].
* The drone will appear somewhere within the allowed_area var, or if no area is specified, at the location of the console.area
* Upon interacting, the user will be granted a set of base building actions that will generally be carried out at the drone's location.
* To create a new base builder system, this class should be the only thing that needs to be subtyped.
@@ -61,7 +61,7 @@
var/turf/spawn_spot = find_spawn_spot()
if (!spawn_spot)
return FALSE
eyeobj = new /mob/camera/ai_eye/remote/base_construction(spawn_spot, src)
eyeobj = new /mob/eye/ai_eye/remote/base_construction(spawn_spot, src)
eyeobj.origin = src
return TRUE
@@ -95,7 +95,7 @@
* The mob is constrained to a given area defined by the base construction console.
*
*/
/mob/camera/ai_eye/remote/base_construction
/mob/eye/ai_eye/remote/base_construction
name = "construction holo-drone"
//Allows any curious crew to watch the base after it leaves. (This is safe as the base cannot be modified once it leaves)
move_on_shuttle = TRUE
@@ -105,20 +105,20 @@
///Reference to the camera console controlling this drone
var/obj/machinery/computer/camera_advanced/base_construction/linked_console
/mob/camera/ai_eye/remote/base_construction/Initialize(mapload, obj/machinery/computer/camera_advanced/console_link)
/mob/eye/ai_eye/remote/base_construction/Initialize(mapload, obj/machinery/computer/camera_advanced/console_link)
linked_console = console_link
if(!linked_console)
stack_trace("A base consturuction drone was created with no linked console")
return INITIALIZE_HINT_QDEL
return ..()
/mob/camera/ai_eye/remote/base_construction/setLoc(turf/destination, force_update = FALSE)
/mob/eye/ai_eye/remote/base_construction/setLoc(turf/destination, force_update = FALSE)
var/area/curr_area = get_area(destination)
//Only move if we're in the allowed area. If no allowed area is defined, then we're free to move wherever.
if(!linked_console.allowed_area || istype(curr_area, linked_console.allowed_area))
return ..()
/mob/camera/ai_eye/remote/base_construction/relaymove(mob/living/user, direction)
/mob/eye/ai_eye/remote/base_construction/relaymove(mob/living/user, direction)
//This camera eye is visible, and as such needs to keep its dir updated
dir = direction
return ..()