[NO GBP] Renames mob/camera to mob/eye and makes everything follow suit (#87684)

## Why It's Good For The Game

Clarity and consistency regarding DM's systems. 
Internally, `eye` is used for anything that controls the client's view.

![image](https://github.com/user-attachments/assets/7d1291e1-7a6a-4736-a14b-97834e89846f)
How `eye` is used in DM is consistent with how we use the term, so I
figured this would add clarity.

Being named mob/camera also makes it unclear exactly what it's doing.
The name implies that it would function similar to how mob/camera/ai_eye
does, but most of the time it's only used as... an eye.

My ulterior reason for this PR is that I want to clean up
mob/camera/ai_eye and it's subtypes after this.
## Changelog

🆑
server: mob/camera has been renamed to mob/eye, which may break
downstreams
/🆑

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
This commit is contained in:
tonty
2024-11-09 10:57:45 +00:00
committed by GitHub
co-authored by Ghom
parent bf2a1b7887
commit d5daa9c9b8
76 changed files with 298 additions and 298 deletions
+2 -2
View File
@@ -323,7 +323,7 @@ This is the proc mobs get to turn into a ghost. Forked from ghostize due to comp
ghostize(FALSE) // FALSE parameter is so we can never re-enter our body. U ded.
return TRUE
/mob/camera/verb/ghost()
/mob/eye/verb/ghost()
set category = "OOC"
set name = "Ghost"
set desc = "Relinquish your life and enter the land of the dead."
@@ -704,7 +704,7 @@ This is the proc mobs get to turn into a ghost. Forked from ghostize due to comp
//this is called when a ghost is drag clicked to something.
/mob/dead/observer/mouse_drop_dragged(atom/over, mob/user)
if (isobserver(user) && user.client.holder && (isliving(over) || iscameramob(over)))
if (isobserver(user) && user.client.holder && (isliving(over) || iseyemob(over)))
user.client.holder.cmd_ghost_drag(src, over)
/mob/dead/observer/Topic(href, href_list)
+2 -2
View File
@@ -285,7 +285,7 @@ GLOBAL_DATUM_INIT(orbit_menu, /datum/orbit_menu, new)
* Helper POI validation function passed as a callback to various SSpoints_of_interest procs.
*
* Provides extended validation above and beyond standard, limiting mob POIs without minds or ckeys
* unless they're mobs, camera mobs or megafauna. Also allows exceptions for mobs that are deadchat controlled.
* unless they're mobs, eye mobs or megafauna. Also allows exceptions for mobs that are deadchat controlled.
*
* If they satisfy that requirement, falls back to default validation for the POI.
*/
@@ -294,7 +294,7 @@ GLOBAL_DATUM_INIT(orbit_menu, /datum/orbit_menu, new)
if(!potential_mob_poi.mind && !potential_mob_poi.ckey)
if(!mob_allowed_typecache)
mob_allowed_typecache = typecacheof(list(
/mob/camera,
/mob/eye,
/mob/living/basic/regal_rat,
/mob/living/simple_animal/bot,
/mob/living/simple_animal/hostile/megafauna,