cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-24 05:30:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

[NO GBP] Renames mob/camera to mob/eye and makes everything follow suit (#87684)

Browse Source 
## Why It's Good For The Game

Clarity and consistency regarding DM's systems. 
Internally, `eye` is used for anything that controls the client's view.

![image](https://github.com/user-attachments/assets/7d1291e1-7a6a-4736-a14b-97834e89846f)
How `eye` is used in DM is consistent with how we use the term, so I
figured this would add clarity.

Being named mob/camera also makes it unclear exactly what it's doing.
The name implies that it would function similar to how mob/camera/ai_eye
does, but most of the time it's only used as... an eye.

My ulterior reason for this PR is that I want to clean up
mob/camera/ai_eye and it's subtypes after this.
## Changelog

🆑
server: mob/camera has been renamed to mob/eye, which may break
downstreams
/🆑

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
This commit is contained in:
tonty
2024-11-09 10:57:45 +00:00
committed by GitHub
co-authored by Ghom
parent bf2a1b7887
commit d5daa9c9b8
76 changed files with 298 additions and 298 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/unit_tests/mob_faction.dm
+3 -3
View File
@@ -8,10 +8,10 @@
/mob/dview,
/mob/oranges_ear
)
ignored += typesof(/mob/camera/imaginary_friend)
ignored += typesof(/mob/eye/imaginary_friend)
ignored += typesof(/mob/living/silicon/robot/model)
ignored += typesof(/mob/camera/ai_eye/remote/base_construction)
ignored += typesof(/mob/camera/ai_eye/remote/shuttle_docker)
ignored += typesof(/mob/eye/ai_eye/remote/base_construction)
ignored += typesof(/mob/eye/ai_eye/remote/shuttle_docker)
for (var/mob_type in typesof(/mob) - ignored)
var/mob/mob_instance = allocate(mob_type)
if(!islist(mob_instance.faction))
code/modules/unit_tests/unit_test.dm
+3 -3
View File
@@ -285,13 +285,13 @@ GLOBAL_VAR_INIT(focused_tests, focused_tests())
//We have a baseturf limit of 10, adding more than 10 baseturf helpers will kill CI, so here's a future edge case to fix.
returnable_list += typesof(/obj/effect/baseturf_helper)
//No tauma to pass in
returnable_list += typesof(/mob/camera/imaginary_friend)
returnable_list += typesof(/mob/eye/imaginary_friend)
//No heart to give
returnable_list += typesof(/obj/structure/ethereal_crystal)
//No linked console
returnable_list += typesof(/mob/camera/ai_eye/remote/base_construction)
returnable_list += typesof(/mob/eye/ai_eye/remote/base_construction)
//See above
returnable_list += typesof(/mob/camera/ai_eye/remote/shuttle_docker)
returnable_list += typesof(/mob/eye/ai_eye/remote/shuttle_docker)
//Hangs a ref post invoke async, which we don't support. Could put a qdeleted check but it feels hacky
returnable_list += typesof(/obj/effect/anomaly/grav/high)
//See above