From d7dba29acb79a2b93051db7abf2cb51a2c45fce4 Mon Sep 17 00:00:00 2001 From: SkyratBot <59378654+SkyratBot@users.noreply.github.com> Date: Sun, 23 Jul 2023 20:10:10 +0200 Subject: [PATCH] [MIRROR] Genetic Sequencers now can scan genetic makeup, not just mutations [MDB IGNORE] (#22643) * Genetic Sequencers now can scan genetic makeup, not just mutations (#76567) ## About The Pull Request Adds a feature to the genetic sequencer geneticists has, you can now right click someone to copy their genetic makeup and export it to the DNA scanner console. ## Why It's Good For The Game QOL but mostly more ammo for antagonist geneticists, the enzyme feature of genetics is seldom used since you need someone to willingly (if they are alive) step inside the machine which is close to impossible. Not to mention the esoteric way you can change them. I feel like the art disguising and deception has been dying and tried to make it easier in #76508 which got closed for stealing genetics neesh. this fixes that problem while still serving the same end goal in an albeit less soulful way ## Changelog :cl: add: You can now use the genetic sequencer secondary click (RMB) to scan someone /:cl: * Genetic Sequencers now can scan genetic makeup, not just mutations --------- Co-authored-by: Singul0 <127663818+Singul0@users.noreply.github.com> Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com> --- .../devices/scanners/sequence_scanner.dm | 47 +++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/code/game/objects/items/devices/scanners/sequence_scanner.dm b/code/game/objects/items/devices/scanners/sequence_scanner.dm index 58f7459b7da..ee2742c55d7 100644 --- a/code/game/objects/items/devices/scanners/sequence_scanner.dm +++ b/code/game/objects/items/devices/scanners/sequence_scanner.dm @@ -20,6 +20,14 @@ var/list/buffer var/ready = TRUE var/cooldown = 200 + /// genetic makeup data that's scanned + var/list/genetic_makeup_buffer = list() + +/obj/item/sequence_scanner/examine(mob/user) + . = ..() + . += span_notice("Use primary attack to scan mutations, Secondary attack to scan genetic makeup") + if(LAZYLEN(genetic_makeup_buffer) > 0) + . += span_notice("It has the genetic makeup of \"[genetic_makeup_buffer["name"]]\" stored inside its buffer") /obj/item/sequence_scanner/attack(mob/living/target, mob/living/carbon/human/user) add_fingerprint(user) @@ -32,6 +40,31 @@ else user.visible_message(span_notice("[user] fails to analyze [target]'s genetic sequence."), span_warning("[target] has no readable genetic sequence!")) +/obj/item/sequence_scanner/attack_secondary(mob/living/target, mob/living/carbon/human/user, max_interact_count = 1) + add_fingerprint(user) + //no scanning if its a husk, DNA-less Species or DNA that isn't able to be copied by a changeling/disease + if (!HAS_TRAIT(target, TRAIT_GENELESS) && !HAS_TRAIT(target, TRAIT_BADDNA) && !HAS_TRAIT(target, TRAIT_NO_DNA_COPY)) + user.visible_message(span_warning("[user] is scanning [target]'s genetic makeup.")) + if(!do_after(user, 3 SECONDS)) + balloon_alert(user, "scan failed!") + user.visible_message(span_warning("[user] fails to scan [target]'s genetic makeup.")) + return SECONDARY_ATTACK_CANCEL_ATTACK_CHAIN + makeup_scan(target, user) + balloon_alert(user, "makeup scanned") + return SECONDARY_ATTACK_CANCEL_ATTACK_CHAIN + else + user.visible_message(span_notice("[user] fails to analyze [target]'s genetic makeup."), span_warning("[target] has no readable genetic makeup!")) + return SECONDARY_ATTACK_CANCEL_ATTACK_CHAIN + +/obj/item/sequence_scanner/afterattack_secondary(obj/object, mob/user, proximity) + . = ..() + if(!istype(object) || !proximity) + return + if(istype(object, /obj/machinery/computer/scan_consolenew)) + var/obj/machinery/computer/scan_consolenew/console = object + var/buffer_index = tgui_input_number(user, "Slot:", "Which slot to export:", 1, LAZYLEN(console.genetic_makeup_buffer), 1) + console.genetic_makeup_buffer[buffer_index] = genetic_makeup_buffer + /obj/item/sequence_scanner/attack_self(mob/user) display_sequence(user) @@ -51,6 +84,7 @@ else to_chat(user,span_warning("No database to update from.")) +///proc for scanning someone's mutations /obj/item/sequence_scanner/proc/gene_scan(mob/living/carbon/target, mob/living/user) if(!iscarbon(target) || !target.has_dna()) return @@ -71,6 +105,19 @@ else to_chat(user, span_notice("[get_display_name(mutation)]")) +///proc for scanning someone's genetic makeup +/obj/item/sequence_scanner/proc/makeup_scan(mob/living/carbon/target, mob/living/user) + if(!iscarbon(target) || !target.has_dna()) + return + + genetic_makeup_buffer = list( + "label"="Analyzer Slot:[target.real_name]", + "UI"=target.dna.unique_identity, + "UE"=target.dna.unique_enzymes, + "UF"=target.dna.unique_features, + "name"=target.real_name, + "blood_type"=target.dna.blood_type) + /obj/item/sequence_scanner/proc/display_sequence(mob/living/user) if(!LAZYLEN(buffer) || !ready) return