Camera eyes have been lightly refactored (among other things...) (#87805)

## About The Pull Request

* A generic /mob/eye/camera type has been made, containing everything
needed to interface with a cameranet
* /mob/eye/ai_eye has been refactored into a generic /mob/eye/camera
instance
* Advanced cameras no longer inherit from AI eyes, splitting off
behaviour
* Camera code has been somewhat cleaned up
* Probably some more stuff I'm forgetting right now

## Big man Southport:

![image](https://github.com/user-attachments/assets/de6e6ff0-ca99-4636-bdec-5e0b2d6b8037)

## Changelog

🆑
code: made /proc/getviewsize() pure

refactor: mob/eye/ai_eye has been restructured, now inheriting from a
generic mob/eye/camera type
refactor: advanced cameras and their subtypes are now
mob/eye/camera/remote subtypes
code: the cameranet no longer expects the user to be an AI eye
code: remote camera eyes have had their initialization streamlined
code: remote cameras handle assigning and unassigning users by
themselves now
code: remote cameras now use weakrefs instead of hard referencing owners
and origins
code: also the sentient disease is_define was removed (we don't have
those anymore)
fix: AI eyes no longer assign real names to themselves, fixing their
orbit name
/🆑

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
This commit is contained in:
tonty
2024-11-21 12:55:38 +01:00
committed by GitHub
co-authored by Ghom
parent 6859e714d0
commit d8450b4933
29 changed files with 477 additions and 361 deletions
+2 -2
View File
@@ -10,8 +10,8 @@
)
ignored += typesof(/mob/eye/imaginary_friend)
ignored += typesof(/mob/living/silicon/robot/model)
ignored += typesof(/mob/eye/ai_eye/remote/base_construction)
ignored += typesof(/mob/eye/ai_eye/remote/shuttle_docker)
ignored += typesof(/mob/eye/camera/remote/base_construction)
ignored += typesof(/mob/eye/camera/remote/shuttle_docker)
for (var/mob_type in typesof(/mob) - ignored)
var/mob/mob_instance = allocate(mob_type)
if(!islist(mob_instance.faction))
+2 -2
View File
@@ -289,9 +289,9 @@ GLOBAL_VAR_INIT(focused_tests, focused_tests())
//No heart to give
returnable_list += typesof(/obj/structure/ethereal_crystal)
//No linked console
returnable_list += typesof(/mob/eye/ai_eye/remote/base_construction)
returnable_list += typesof(/mob/eye/camera/remote/base_construction)
//See above
returnable_list += typesof(/mob/eye/ai_eye/remote/shuttle_docker)
returnable_list += typesof(/mob/eye/camera/remote/shuttle_docker)
//Hangs a ref post invoke async, which we don't support. Could put a qdeleted check but it feels hacky
returnable_list += typesof(/obj/effect/anomaly/grav/high)
//See above