[READY] Fishing and aquarium expansion. (#76531)

Listing the changes, off the top of my head:
- Resprited fishing rods, hooks, and the worm bait!
- Added a new, telescopic fishing rod, that can be bought as a goodie.
The master rod is also telescopic now.
- Added a couple hooks. One that lets you move the bait up and down,
otherwise keeping it in place, and another that stops the fish from
escaping, but slowly kills it. The former from the bepis fishing tech
node, the latter frm the black market.
- Added a fishing skill and relative legendary reward: A fishing hat,
like the one that recites "women fear me, fish fear me"
- You can now stop fishing by activating the fishing rod in your hand,
and stops it from stealing all clicks on other things if it isn't in
your active hand.
- Reworked fishing traits into fish traits, which can apply to fish
after it has been caught.
- Expanded the fish breeding system. Traits may be passed down to
offsprings, and offsprings may evolve (mutate?) into different kind of
fishes if conditions when conditions are met.
- Added half a dozen new fishes, each with its own traits: lubefish,
sludgefish (and its purple variant), slimefish, unmarine bonemass and
unmarine mastodon. Also, holodeck fish, as a joke.
- New traits: lubed skin, parthenogenesis, toxic (new reagent), toxin
immunity, predator, necrophage, no mating, crossbreeder, aggressive and
revival. Converted Emulsijack's ability and Donkfish's yuckiness into
traits as well.
- Added a fish analyzer that you can scan aquariums and fishes with.
- Fish can now be blended if you really want to. The number of reagents
from blending, w_class, and the number of fillets you get from cutting
fish now scale with size and weight.
- fish feed is no longer infinite (but it should still be plenty).
- Implemented temperature requirements for aquarium fish.
- You can now buy (dead) fish from the black market for dirt cheap.
- Last but now least, toilets are now valid fishing spots.

code/modules/holodeck/computer.dm

@@ -269,42 +269,54 @@ GLOBAL_LIST_INIT(typecache_holodeck_linked_floorcheck_ok, typecacheof(list(/turf
 		if(QDELETED(holo_atom))
 			spawned -= holo_atom
 			continue
-
-		RegisterSignal(holo_atom, COMSIG_QDELETING, PROC_REF(remove_from_holo_lists))
-		holo_atom.flags_1 |= HOLOGRAM_1
-
-		if(isholoeffect(holo_atom))//activates holo effects and transfers them from the spawned list into the effects list
-			var/obj/effect/holodeck_effect/holo_effect = holo_atom
-			effects += holo_effect
-			spawned -= holo_effect
-			var/atom/holo_effect_product = holo_effect.activate(src)//change name
-			if(istype(holo_effect_product))
-				spawned += holo_effect_product // we want mobs or objects spawned via holoeffects to be tracked as objects
-				RegisterSignal(holo_effect_product, COMSIG_QDELETING, PROC_REF(remove_from_holo_lists))
-			if(islist(holo_effect_product))
-				for(var/atom/atom_product as anything in holo_effect_product)
-					RegisterSignal(atom_product, COMSIG_QDELETING, PROC_REF(remove_from_holo_lists))
-			continue
-
-		if(isobj(holo_atom))
-			var/obj/holo_object = holo_atom
-			holo_object.resistance_flags = LAVA_PROOF | FIRE_PROOF | UNACIDABLE | ACID_PROOF
-
-			if(isstructure(holo_object))
-				holo_object.flags_1 |= NODECONSTRUCT_1
-				continue
-
-			if(ismachinery(holo_object))
-				var/obj/machinery/holo_machine = holo_object
-				holo_machine.flags_1 |= NODECONSTRUCT_1
-				holo_machine.power_change()
-
-				if(istype(holo_machine, /obj/machinery/button))
-					var/obj/machinery/button/holo_button = holo_machine
-					holo_button.setup_device()
-
+		finalize_spawned(holo_atom)
 	spawning_simulation = FALSE
 
+/obj/machinery/computer/holodeck/proc/finalize_spawned(atom/holo_atom)
+	RegisterSignal(holo_atom, COMSIG_QDELETING, PROC_REF(remove_from_holo_lists))
+	holo_atom.flags_1 |= HOLOGRAM_1
+
+	if(isholoeffect(holo_atom))//activates holo effects and transfers them from the spawned list into the effects list
+		var/obj/effect/holodeck_effect/holo_effect = holo_atom
+		effects += holo_effect
+		spawned -= holo_effect
+		var/atom/holo_effect_product = holo_effect.activate(src)//change name
+		if(istype(holo_effect_product))
+			spawned += holo_effect_product // we want mobs or objects spawned via holoeffects to be tracked as objects
+			RegisterSignal(holo_effect_product, COMSIG_QDELETING, PROC_REF(remove_from_holo_lists))
+		if(islist(holo_effect_product))
+			for(var/atom/atom_product as anything in holo_effect_product)
+				RegisterSignal(atom_product, COMSIG_QDELETING, PROC_REF(remove_from_holo_lists))
+		return
+
+	if(isobj(holo_atom))
+		var/obj/holo_object = holo_atom
+		holo_object.resistance_flags = LAVA_PROOF | FIRE_PROOF | UNACIDABLE | ACID_PROOF
+
+		if(isstructure(holo_object))
+			holo_object.flags_1 |= NODECONSTRUCT_1
+			return
+
+		if(ismachinery(holo_object))
+			var/obj/machinery/holo_machine = holo_object
+			holo_machine.flags_1 |= NODECONSTRUCT_1
+			holo_machine.power_change()
+
+			if(istype(holo_machine, /obj/machinery/button))
+				var/obj/machinery/button/holo_button = holo_machine
+				holo_button.setup_device()
+
+/**
+ * A separate proc for objects that weren't loaded by the template nor spawned by holo effects
+ * yet need to be added to the list of spawned objects. (e.g. holographic fishes)
+ */
+/obj/machinery/computer/holodeck/proc/add_to_spawned(atom/holo_atom)
+	spawned |= holo_atom
+	if(!(obj_flags & EMAGGED) && isitem(holo_atom))
+		var/obj/item/to_be_nerfed = holo_atom
+		to_be_nerfed.damtype = STAMINA
+	finalize_spawned(holo_atom)
+
 ///this qdels holoitems that should no longer exist for whatever reason
 /obj/machinery/computer/holodeck/proc/derez(atom/movable/holo_atom, silent = TRUE, forced = FALSE)
 	spawned -= holo_atom

code/modules/holodeck/turfs.dm

@@ -91,6 +91,10 @@
 	icon_state = "water"
 	bullet_sizzle = TRUE
 
+/turf/open/floor/holofloor/beach/water/Initialize(mapload)
+	. = ..()
+	AddComponent(/datum/component/fishing_spot, /datum/fish_source/holographic)
+
 /turf/open/floor/holofloor/asteroid
 	gender = PLURAL
 	name = "asteroid sand"