From d9c8ffef604daaaf6b93a58a37e83447da6f7bf4 Mon Sep 17 00:00:00 2001 From: SkyratBot <59378654+SkyratBot@users.noreply.github.com> Date: Mon, 1 Feb 2021 14:23:29 +0100 Subject: [PATCH] [MIRROR] Changed the population scaling coefficients minimal values to 0. (#2995) * Changed the population scaling coefficients minimal values to 0. (#56522) ## About The Pull Request So, there on the downstream we've encountered a problem with the security officer slots jumping to 12 every time the round starts, regardless of what we set them to in the configs. In the configs it says that you can set the coefficients to 0 to disable scaling, and upon investigation, it seems that all the scaling coefficients suffer from similar problem. https://github.com/tgstation/tgstation/blob/master/config/game_options.txt#L198 the `min_val` in the config entry datums is 1 on each of them, leading to unexpected behaviour ## Why It's Good For The Game It fixes certain config values leading to unexpected and unwanted behaviour * Changed the population scaling coefficients minimal values to 0. Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com> --- code/controllers/configuration/entries/game_options.dm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/code/controllers/configuration/entries/game_options.dm b/code/controllers/configuration/entries/game_options.dm index 13d73d08298..c9517a97bbb 100644 --- a/code/controllers/configuration/entries/game_options.dm +++ b/code/controllers/configuration/entries/game_options.dm @@ -71,27 +71,27 @@ /datum/config_entry/number/traitor_scaling_coeff //how much does the amount of players get divided by to determine traitors config_entry_value = 6 integer = FALSE - min_val = 1 + min_val = 0 /datum/config_entry/number/brother_scaling_coeff //how many players per brother team config_entry_value = 25 integer = FALSE - min_val = 1 + min_val = 0 /datum/config_entry/number/changeling_scaling_coeff //how much does the amount of players get divided by to determine changelings config_entry_value = 6 integer = FALSE - min_val = 1 + min_val = 0 /datum/config_entry/number/ecult_scaling_coeff //how much does the amount of players get divided by to determine e_cult config_entry_value = 6 integer = FALSE - min_val = 1 + min_val = 0 /datum/config_entry/number/security_scaling_coeff //how much does the amount of players get divided by to determine open security officer positions config_entry_value = 8 integer = FALSE - min_val = 1 + min_val = 0 /datum/config_entry/number/traitor_objectives_amount config_entry_value = 2