From dc2afeb653dd8515e50ed895ff4d1fa18dc7581f Mon Sep 17 00:00:00 2001 From: SkyratBot <59378654+SkyratBot@users.noreply.github.com> Date: Sun, 25 Dec 2022 07:00:39 +0100 Subject: [PATCH] [MIRROR] Replace moveToNullspace in decal Destroy() to loc = null -- Saves 0.11s of init time [MDB IGNORE] (#18188) * Replace moveToNullspace in decal Destroy() to loc = null -- Saves 0.11s of init time (#71706) This calls Exited(), Entered(), etc etc etc etc, and it is not necessary for this. Was 119ms, now 9. * Replace moveToNullspace in decal Destroy() to loc = null -- Saves 0.11s of init time Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> --- code/game/objects/effects/decals/decal.dm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/code/game/objects/effects/decals/decal.dm b/code/game/objects/effects/decals/decal.dm index 2c4e3fc164d..40e622b5225 100644 --- a/code/game/objects/effects/decals/decal.dm +++ b/code/game/objects/effects/decals/decal.dm @@ -62,5 +62,8 @@ var/turf/T = loc T.RemoveElement(/datum/element/decal, icon, icon_state, dir, null, null, alpha, color, null, FALSE, null) #endif - moveToNullspace() + // Intentionally used over moveToNullspace(), which calls doMove(), which fires + // off an enormous amount of procs, signals, etc, that this temporary effect object + // never needs or affects. + loc = null return QDEL_HINT_QUEUE