Prevents Debug ID Card from Polluting Cargo Budget By Doing It Right (#82214)

## About The Pull Request

Fixes #81755

Alright instead of piggybacking off the departmental/non-departmental
distinction and prevent ourselves from constantly abusing the cargo
budget in order to achieve the very-specific effect of not wanting
players to abuse this card in certain contexts let's just leverage the
framework and expand it so that we can snowflake for admin/`holder` use
cases in stuff like debugging code on a local server while preventing
some player from stealing it off a newbie admin and immediately wrecking
the economy (although it is funny).
## Why It's Good For The Game

Probably a bad idea to continue to abuse the cargo budget like this
since the only reason why it's structured that way is just for specific
use-case exemptions in certain contexts - let's just do our own thing
now :3
## Changelog
🆑
admin: Advanced Debug Cards will still provide a whole lot of access,
but the way the money on those cards work is now a bit different.
Players shouldn't be able to use the money on those cards in any context
though, don't fret about that. Just know that the money printer goes
wrrrr
/🆑

---------

Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com>
This commit is contained in:
san7890
2024-03-27 19:11:41 +01:00
committed by GitHub
co-authored by Zephyr
parent 874a6f4a5e
commit dc5e87e545
5 changed files with 38 additions and 10 deletions
+1 -1
View File
@@ -256,7 +256,7 @@
if(!id_card)
to_chat(user, span_warning("You don't even have a id and you want to be an art patron?"))
return
if(!id_card.registered_account || !id_card.registered_account.account_job)
if(!id_card.can_be_used_in_payment(user))
to_chat(user, span_warning("No valid non-departmental account found."))
return
var/datum/bank_account/account = id_card.registered_account