cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-22 20:48:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

Reverts the recent config changes (#56606)

Browse Source 
* Revert "Fixes included config files not loading (#56602)"

This reverts commit 0749b322f6.

* Revert "Adds configuration consistency tests (#56562)"

This reverts commit 4f44014e25.
This commit is contained in:
LemonInTheDark
2021-02-02 22:14:47 -05:00
committed by GitHub
parent ef73b284e6
commit dd6cea82d9
10 changed files with 71 additions and 176 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/unit_tests/_unit_tests.dm
-1
View File
@@ -44,7 +44,6 @@
#include "chain_pull_through_space.dm"
#include "combat.dm"
#include "component_tests.dm"
#include "configuration_documentation.dm"
#include "confusion.dm"
#include "designs.dm"
#include "emoting.dm"
code/modules/unit_tests/configuration_documentation.dm
-63
View File
@@ -1,63 +0,0 @@
/datum/unit_test/configuration_documentation
/// List of undocumented config entries
var/list/undocumented_entries
/// List of set config entries with no code equivalent
var/list/extraneous_entries
/// List of entries seen already
var/list/seen_entries
/datum/unit_test/configuration_documentation/Run()
undocumented_entries = list()
for(var/entry_key in global.config.entries)
var/datum/config_entry/config_entry = global.config.entries[entry_key]
if(!config_entry.deprecated_by)
undocumented_entries += entry_key
extraneous_entries = list()
seen_entries = list()
var/test_config_file = world.params["original_config"] ? world.params["original_config"] : DEFAULT_CONFIGURATION_FILE
TestGraph(test_config_file)
if(undocumented_entries.len)
Fail("The following configuration entries are missing default values in the .txt (commented out or otherwise): [english_list(undocumented_entries)]")
if(extraneous_entries.len)
Fail("The following configuration entries do not have a match in code: [english_list(extraneous_entries)]")
/****
* Test a graph of config files inclusions
* filename - The file to test
* stack - Used for recursive calls to prevent repeat parsing
*/
/datum/unit_test/configuration_documentation/proc/TestGraph(filename, list/stack = list())
var/filename_to_test = world.system_type == MS_WINDOWS ? lowertext(filename) : filename
if(filename_to_test in stack)
Fail("Config recursion detected ([english_list(stack)])!")
return
stack = stack + filename_to_test
var/list/parsed_entries = global.config.ParseConfigFile(filename_to_test)
for(var/entry in parsed_entries)
if(!entry)
// Commented out entries
for(var/disabled_entry in parsed_entries[entry])
TryRemoveEntry(disabled_entry, filename_to_test)
else if(entry == CONFIGURATION_INCLUDE_TOKEN)
for(var/sub_config in parsed_entries[entry])
TestGraph(sub_config, stack)
else
TryRemoveEntry(entry, filename_to_test)
/****
* Attempt to update undocumented_entries and extraneous_entries
* entry - The detected entry
* filename - The containing filename
*/
/datum/unit_test/configuration_documentation/proc/TryRemoveEntry(entry, filename)
entry = lowertext(entry)
var/start_len = undocumented_entries.len
undocumented_entries -= entry
if(!seen_entries[entry])
seen_entries[entry] = TRUE
if(undocumented_entries.len == start_len)
extraneous_entries[entry] = filename