From dd9bfacdb56ff300fdba4c530e915e1fd360e4e1 Mon Sep 17 00:00:00 2001 From: monster860 Date: Mon, 12 Nov 2018 16:28:20 -0500 Subject: [PATCH] Make tank transfer valve icon code suck less (#41425) What the fuck kind of person creates a new icon file EVERY TIME SOMETHING CHANGES just to move something 13 pixels to the left? --- code/game/objects/items/devices/transfer_valve.dm | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/code/game/objects/items/devices/transfer_valve.dm b/code/game/objects/items/devices/transfer_valve.dm index a980a5b1c80..1c48dea1a15 100644 --- a/code/game/objects/items/devices/transfer_valve.dm +++ b/code/game/objects/items/devices/transfer_valve.dm @@ -137,7 +137,6 @@ /obj/item/transfer_valve/update_icon() cut_overlays() - underlays = null if(!tank_one && !tank_two && !attached_device) icon_state = "valve_1" @@ -147,9 +146,13 @@ if(tank_one) add_overlay("[tank_one.icon_state]") if(tank_two) - var/icon/J = new(icon, icon_state = "[tank_two.icon_state]") - J.Shift(WEST, 13) - underlays += J + var/mutable_appearance/J = mutable_appearance(icon, icon_state = "[tank_two.icon_state]") + var/matrix/T = matrix() + T.Translate(-13, 0) + J.transform = T + underlays = list(J) + else + underlays = null if(attached_device) add_overlay("device") if(istype(attached_device, /obj/item/assembly/infra))