mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-27 07:08:00 +01:00
Fix some new dreamchecker lints (#91844)
## About The Pull Request
https://github.com/SpaceManiac/SpacemanDMM/pull/435 added a new
dreamchecker lint, for SDMM `set` statements not at the top of the proc.
While this lint isn't in the current SDMM _release_, I was testing it
out earlier and saw these issues, so might as well fix them before they
even become an issue.
i also fixed a useless variable in moon heretic code that was right next
to the incorrectly placed `SIGNAL_HANDLER`
## Why It's Good For The Game
https://github.com/user-attachments/assets/5b063f41-32f3-490a-b0a3-199ca8147ec3
## Changelog
No player-facing changes.
(cherry picked from commit a2a43e2851)
This commit is contained in:
@@ -32,8 +32,8 @@ GLOBAL_LIST_EMPTY(fishes_by_fish_evolution)
|
||||
var/show_result_on_wiki = TRUE
|
||||
|
||||
/datum/fish_evolution/New()
|
||||
..()
|
||||
SHOULD_CALL_PARENT(TRUE)
|
||||
..()
|
||||
if(!ispath(new_fish_type, /obj/item/fish))
|
||||
stack_trace("[type] instantiated with a new fish type of [new_fish_type]. That's not a fish, hun, things will break.")
|
||||
if(!name)
|
||||
|
||||
Reference in New Issue
Block a user