From df9560bf2eb6ce922ad555f46aebbe50959f9975 Mon Sep 17 00:00:00 2001 From: SkyratBot <59378654+SkyratBot@users.noreply.github.com> Date: Thu, 15 Aug 2024 11:51:09 +0200 Subject: [PATCH] [MIRROR] puts all the default command programs on /pda/heads rather than their specific role (#29309) * puts all the default command programs on /pda/heads rather than their specific role (#85228) ## About The Pull Request Makes it so the default programs in the head PDAs actually works so all 5 do not need to be rewritten for each and every head of staff PDA ## Why It's Good For The Game there were an unnecessary 5 lines of code per head (minus the captain), this reduces it to just the special additions they get ## Proof of Testing ![image](https://github.com/user-attachments/assets/64da42f1-d4b3-4e9e-82f5-ee7a3f01f463) ## Changelog :cl: code: made it look a little cleaner for head PDAs /:cl: * puts all the default command programs on /pda/heads rather than their specific role --------- Co-authored-by: Odairu --- .../computers/item/role_tablet_presets.dm | 38 ++++--------------- 1 file changed, 7 insertions(+), 31 deletions(-) diff --git a/code/modules/modular_computers/computers/item/role_tablet_presets.dm b/code/modules/modular_computers/computers/item/role_tablet_presets.dm index 2261f775ec8..5c7f95d54e9 100644 --- a/code/modules/modular_computers/computers/item/role_tablet_presets.dm +++ b/code/modules/modular_computers/computers/item/role_tablet_presets.dm @@ -6,7 +6,7 @@ greyscale_config = /datum/greyscale_config/tablet/head greyscale_colors = "#67A364#a92323" max_capacity = parent_type::max_capacity * 2 - starting_programs = list( + var/static/list/datum/computer_file/head_programs = list( /datum/computer_file/program/crew_manifest, /datum/computer_file/program/status, /datum/computer_file/program/science, @@ -14,6 +14,12 @@ /datum/computer_file/program/budgetorders, ) +/obj/item/modular_computer/pda/heads/Initialize(mapload) + . = ..() + for(var/programs in head_programs) + var/datum/computer_file/program/program_type = new programs + store_file(program_type) + /obj/item/modular_computer/pda/heads/captain name = "captain PDA" greyscale_config = /datum/greyscale_config/tablet/captain @@ -35,11 +41,6 @@ greyscale_config = /datum/greyscale_config/tablet/stripe_thick/head greyscale_colors = "#374f7e#a52f29#a52f29" starting_programs = list( - /datum/computer_file/program/crew_manifest, - /datum/computer_file/program/status, - /datum/computer_file/program/science, - /datum/computer_file/program/robocontrol, - /datum/computer_file/program/budgetorders, /datum/computer_file/program/records/security, /datum/computer_file/program/job_management, ) @@ -50,11 +51,6 @@ greyscale_colors = "#EA3232#0000CC" inserted_item = /obj/item/pen/red/security starting_programs = list( - /datum/computer_file/program/crew_manifest, - /datum/computer_file/program/status, - /datum/computer_file/program/science, - /datum/computer_file/program/robocontrol, - /datum/computer_file/program/budgetorders, /datum/computer_file/program/records/security, ) @@ -63,11 +59,6 @@ greyscale_config = /datum/greyscale_config/tablet/stripe_thick/head greyscale_colors = "#D99A2E#69DBF3#FAFAFA" starting_programs = list( - /datum/computer_file/program/crew_manifest, - /datum/computer_file/program/status, - /datum/computer_file/program/science, - /datum/computer_file/program/robocontrol, - /datum/computer_file/program/budgetorders, /datum/computer_file/program/atmosscan, /datum/computer_file/program/alarm_monitor, /datum/computer_file/program/supermatter_monitor, @@ -78,11 +69,6 @@ greyscale_config = /datum/greyscale_config/tablet/stripe_thick/head greyscale_colors = "#FAFAFA#000099#3F96CC" starting_programs = list( - /datum/computer_file/program/crew_manifest, - /datum/computer_file/program/status, - /datum/computer_file/program/science, - /datum/computer_file/program/robocontrol, - /datum/computer_file/program/budgetorders, /datum/computer_file/program/maintenance/phys_scanner, /datum/computer_file/program/records/medical, ) @@ -94,12 +80,7 @@ inserted_item = /obj/item/pen/fountain starting_programs = list( /datum/computer_file/program/borg_monitor, - /datum/computer_file/program/budgetorders, - /datum/computer_file/program/crew_manifest, - /datum/computer_file/program/robocontrol, - /datum/computer_file/program/science, /datum/computer_file/program/scipaper_program, - /datum/computer_file/program/status, /datum/computer_file/program/signal_commander, ) @@ -110,11 +91,6 @@ inserted_item = /obj/item/pen/survival stored_paper = 20 starting_programs = list( - /datum/computer_file/program/crew_manifest, - /datum/computer_file/program/status, - /datum/computer_file/program/science, - /datum/computer_file/program/robocontrol, - /datum/computer_file/program/budgetorders, /datum/computer_file/program/shipping, /datum/computer_file/program/restock_tracker, )