cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-24 05:30:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixes manifest hard dels (#92283)

Browse Source 
## About The Pull Request

<img width="378" height="199" alt="1eSxYbsh0e"
src="https://github.com/user-attachments/assets/e8a658ca-c1c4-48fe-bb51-c77c85a7f824"
/>

Noticed some hard dels here, does some light refactoring/code
improvement to ensure that doesn't happen.

Crates shouldn't really be owning a hard ref to the manifest in the
first place since they are detachable. Removes some code duplication in
favor of calling `tear_manifest()` which has the safety check to prevent
`forceMove()`ing a qdeleted manifest out of nullspace.

## Why It's Good For The Game

Less server hiccups.

## Changelog

Nothing players will notice besides less server hiccups.
This commit is contained in:
Bloop
2025-07-30 17:37:33 -04:00
committed by Roxy
parent 0b677b689a
commit e3f30b5da8
3 changed files with 17 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/bitrunning/server/loot.dm
+1 -1
View File
@@ -46,7 +46,7 @@
certificate.update_appearance()
var/obj/structure/closet/crate/secure/bitrunning/decrypted/reward_cache = new(src, generated_domain, bonus)
reward_cache.manifest = certificate
reward_cache.manifest = WEAKREF(certificate)
reward_cache.update_appearance()
if(can_generate_tech_disk(grade))