diff --git a/code/__HELPERS/filters.dm b/code/__HELPERS/filters.dm index 7be7ca5d732..cd44409ddb2 100644 --- a/code/__HELPERS/filters.dm +++ b/code/__HELPERS/filters.dm @@ -22,15 +22,16 @@ GLOBAL_LIST_INIT(master_filter_info, list( "size" = 1 ) ), - /* Not supported because making a proper matrix editor on the frontend would be a huge dick pain. - Uncomment if you ever implement it + // Not implemented, but if this isn't uncommented some windows will just error + // Needs either a proper matrix editor, or just a hook to our existing one + // Issue is filterrific assumes variables will have the same value type if they share the same name, which this violates + // Gotta refactor this sometime "color" = list( "defaults" = list( "color" = matrix(), "space" = FILTER_COLOR_RGB ) ), - */ "displace" = list( "defaults" = list( "x" = 0, diff --git a/code/__HELPERS/lighting.dm b/code/__HELPERS/lighting.dm index 4d0105532e4..cb6fd5ea049 100644 --- a/code/__HELPERS/lighting.dm +++ b/code/__HELPERS/lighting.dm @@ -14,7 +14,7 @@ var/mutable_appearance/blocker = new() blocker.icon = make_blocker.icon blocker.icon_state = make_blocker.icon_state - blocker.layer = make_blocker.layer + // blocker.layer = FLOAT_LAYER // Implied, FLOAT_LAYER is default for appearances blocker.appearance_flags |= make_blocker.appearance_flags | EMISSIVE_APPEARANCE_FLAGS blocker.dir = make_blocker.dir blocker.color = GLOB.em_block_color diff --git a/code/game/area/areas.dm b/code/game/area/areas.dm index 9de77fd83be..dc261df5ae7 100644 --- a/code/game/area/areas.dm +++ b/code/game/area/areas.dm @@ -177,8 +177,11 @@ GLOBAL_LIST_EMPTY(teleportlocs) if(!ambientsounds) ambientsounds = GLOB.ambience_assoc[ambience_index] - if(area_flags & AREA_USES_STARLIGHT) - static_lighting = CONFIG_GET(flag/starlight) + if(area_flags & AREA_USES_STARLIGHT && CONFIG_GET(flag/starlight)) + // Areas lit by starlight are not supposed to be fullbright 4head + base_lighting_alpha = 0 + base_lighting_color = null + static_lighting = TRUE if(requires_power) luminosity = 0