From e8c275927a59667bfc0cf6146b466aee80fc8a06 Mon Sep 17 00:00:00 2001
From: Waterpig <49160555+Majkl-J@users.noreply.github.com>
Date: Fri, 28 Jun 2024 12:17:21 +0200
Subject: [PATCH] Captain office access can't magically grant you AA anymore
 (#1615)

## About The Pull Request

See name, you can no longer give yourself ID modification access just by
having captain access

## Why It's Good For The Game

This is unintended behaviour, and results in certain roles abusing it to
grant themselves access without going through the respective heads of
staff.

This was already discussed in the team and with staff before. We
concluded it wasn't needed then and boiled it down to a specific player
issue. But since it keeps resurfacing repeatedly and shouldn't happen in
the first place, it is to be killed.

## Changelog

:cl:
fix: Captain office access can't magically grant you AA anymore
/:cl:
---
 code/modules/modular_computers/file_system/programs/card.dm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/code/modules/modular_computers/file_system/programs/card.dm b/code/modules/modular_computers/file_system/programs/card.dm
index a9bbff8db1b..ca09f452500 100644
--- a/code/modules/modular_computers/file_system/programs/card.dm
+++ b/code/modules/modular_computers/file_system/programs/card.dm
@@ -59,6 +59,10 @@
 	for(var/access_as_text in managers)
 		var/list/info = managers[access_as_text]
 		var/access = access_as_text
+		// BUBBER EDIT START - No weird captain bypass
+		if(access == ACCESS_CAPTAIN)
+			continue
+		// BUBBER EDIT END
 		if((access in auth_card.access) && ((target_dept in info["regions"]) || !target_dept))
 			region_access |= info["regions"]
 			job_templates |= info["templates"]