Add lints for idiomatic balloon alert usage (#72280)

Adds lints for `balloon_alert(span_xxx(...))` (which is always wrong),
and balloon alert where the first letter is a capital (which is usually
wrong). Fixes everything that failed them. As a reminder, abbreviations
like "AI" and "GPS" shouldn't be capitalized in a balloon alert.

In cases where this is intentional for flavor (there was one case), you
can `UNLINT` like so:

Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com>
This commit is contained in:
Mothblocks
2022-12-29 19:01:45 +00:00
committed by GitHub
co-authored by Zephyr
parent 2b1ef0a7ed
commit e9351f6ae0
28 changed files with 73 additions and 57 deletions
+1 -1
View File
@@ -35,7 +35,7 @@
return
set_anchored(!anchored)
tool.play_tool_sound(src)
balloon_alert(user, "You [anchored?"secure":"unsecure"] [src].")
balloon_alert(user, anchored ? "secured" : "unsecured")
return TRUE
+1 -1
View File
@@ -22,7 +22,7 @@
return
set_anchored(!anchored)
tool.play_tool_sound(src)
balloon_alert(user, "You [anchored?"secure":"unsecure"] [src].")
balloon_alert(user, anchored ? "secured" : "unsecured")
return TRUE
/obj/structure/scanner_gate_shell/proc/on_entered(datum/source, atom/movable/AM)
+1 -1
View File
@@ -20,5 +20,5 @@
/obj/structure/server/wrench_act(mob/living/user, obj/item/tool)
set_anchored(!anchored)
tool.play_tool_sound(src)
balloon_alert(user, "You [anchored?"secure":"unsecure"] [src].")
balloon_alert(user, anchored ? "secured" : "unsecured")
return TRUE