From e9b7bfb3899c55b1e43977f6ce57d6ca7dd19668 Mon Sep 17 00:00:00 2001 From: Kyle Spier-Swenson Date: Tue, 3 Jan 2017 13:11:36 -0800 Subject: [PATCH] Fixes sdql2 applying comparison operators to lists incorrectly (#22627) * Fixes sdql2 applying comparison operators to lists incorrectly * Add a comment to prevent future reverts Just in case * Removes oranges comment I'm fucking sick and tired of this shit where people touch code they don't understand. By adding the comment, you imply that every bit of code thats the same without the same comment is safe to change, but thats not true. These landmines are important for teaching new coders not to fuck with shit they don't understand. When you see something and go "why is it doing it that way". the answer is not to go "fuck it, it seems to still work when i change it" the answer is to leave it the fuck alone until it doing it that way is actually an issue. How many god damn bugs have we had this last year from non-changes like that. I'm sick of them. --- code/modules/admin/verbs/SDQL2/SDQL_2.dm | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/code/modules/admin/verbs/SDQL2/SDQL_2.dm b/code/modules/admin/verbs/SDQL2/SDQL_2.dm index 4dc8490eceb..fbc2855f556 100644 --- a/code/modules/admin/verbs/SDQL2/SDQL_2.dm +++ b/code/modules/admin/verbs/SDQL2/SDQL_2.dm @@ -304,19 +304,19 @@ if(op != "") switch(op) if("+") - result += val + result = (result + val) if("-") - result -= val + result = (result - val) if("*") - result *= val + result = (result * val) if("/") - result /= val + result = (result / val) if("&") - result &= val + result = (result & val) if("|") - result |= val + result = (result | val) if("^") - result ^= val + result = (result ^ val) if("=", "==") result = (result == val) if("!=", "<>")