Bools and returns super-pr (#53221) (#565)

Replaces like 70-80% of 0 and such, as a side effect cleaned up a bunch of returns
Edit: Most left out ones are in mecha which should be done in mecha refactor already
Oh my look how clean it is

Co-authored-by: TiviPlus <TiviPlus>
Co-authored-by: Couls <coul422@gmail.com>

Co-authored-by: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Co-authored-by: Couls <coul422@gmail.com>
This commit is contained in:
SkyratBot
2020-08-30 05:12:59 +02:00
committed by GitHub
co-authored by TiviPlus <TiviPlus> Couls TiviPlus
parent f600605607
commit ec09510459
355 changed files with 1549 additions and 1591 deletions
+5 -4
View File
@@ -2,9 +2,10 @@
// used ONLY on april's fool. I moved it to a component so it could be
// used in other places
//This is copypasted on other obj so if you are readin this go refactor it, start on objs with var/limiting_spam
/datum/component/honkspam
dupe_mode = COMPONENT_DUPE_UNIQUE
var/spam_flag = FALSE
var/limiting_spam = FALSE
/datum/component/honkspam/Initialize()
if(!isitem(parent))
@@ -12,11 +13,11 @@
RegisterSignal(parent, COMSIG_ITEM_ATTACK_SELF, .proc/interact)
/datum/component/honkspam/proc/reset_spamflag()
spam_flag = FALSE
limiting_spam = FALSE
/datum/component/honkspam/proc/interact(mob/user)
if(!spam_flag)
spam_flag = TRUE
if(!limiting_spam)
limiting_spam = TRUE
var/obj/item/parent_item = parent
playsound(parent_item.loc, 'sound/items/bikehorn.ogg', 50, TRUE)
addtimer(CALLBACK(src, .proc/reset_spamflag), 2 SECONDS)
+2 -2
View File
@@ -257,7 +257,7 @@
else
if(the_event.timeout)
addtimer(CALLBACK(src, .proc/clear_event, null, category), the_event.timeout, TIMER_UNIQUE|TIMER_OVERRIDE)
return 0 //Don't have to update the event.
return //Don't have to update the event.
var/list/params = args.Copy(4)
params.Insert(1, parent)
the_event = new type(arglist(params))
@@ -276,7 +276,7 @@
category = REF(category)
var/datum/mood_event/event = mood_events[category]
if(!event)
return 0
return
mood_events -= category
qdel(event)
+2 -2
View File
@@ -40,9 +40,9 @@
/datum/component/spawner/proc/try_spawn_mob()
var/atom/P = parent
if(spawned_mobs.len >= max_mobs)
return 0
return
if(spawn_delay > world.time)
return 0
return
spawn_delay = world.time + spawn_time
var/chosen_mob_type = pick(mob_types)
var/mob/living/simple_animal/L = new chosen_mob_type(P.loc)
+3 -3
View File
@@ -52,11 +52,11 @@
/datum/component/summoning/proc/do_spawn_mob(atom/spawn_location, summoner)
if(spawned_mobs.len >= max_mobs)
return 0
return
if(last_spawned_time > world.time)
return 0
return
if(!prob(spawn_chance))
return 0
return
last_spawned_time = world.time + spawn_delay
var/chosen_mob_type = pick(mob_types)
var/mob/living/simple_animal/L = new chosen_mob_type(spawn_location)