diff --git a/code/modules/client/client_procs.dm b/code/modules/client/client_procs.dm index b1d06cb083c..364b3478b0b 100644 --- a/code/modules/client/client_procs.dm +++ b/code/modules/client/client_procs.dm @@ -37,12 +37,13 @@ GLOBAL_LIST_INIT(blacklisted_builds, list( return // asset_cache + var/asset_cache_job if(href_list["asset_cache_confirm_arrival"]) - var/job = round(text2num(href_list["asset_cache_confirm_arrival"])) + asset_cache_job = round(text2num(href_list["asset_cache_confirm_arrival"])) //because we skip the limiter, we have to make sure this is a valid arrival and not somebody tricking us // into letting append to a list without limit. - if (job > 0 && job <= last_asset_job && !(job in completed_asset_jobs)) - completed_asset_jobs += job + if (asset_cache_job > 0 && asset_cache_job <= last_asset_job && !(asset_cache_job in completed_asset_jobs)) + completed_asset_jobs += asset_cache_job return var/mtl = CONFIG_GET(number/minute_topic_limit) @@ -82,7 +83,7 @@ GLOBAL_LIST_INIT(blacklisted_builds, list( log_href("[src] (usr:[usr]\[[COORD(usr)]\]) : [hsrc ? "[hsrc] " : ""][href]") //byond bug ID:2256651 - if (href_list["asset_cache_confirm_arrival"] && href_list["asset_cache_confirm_arrival"] in completed_asset_jobs) + if (asset_cache_job && asset_cache_job in completed_asset_jobs) to_chat(src, "An error has been detected in how your client is receiving resources. Attempting to correct.... (If you keep seeing these messages you might want to close byond and reconnect)") src << browse("...", "window=asset_cache_browser")