From f19611ff772f436d6852bce2e254fdc8e9fb8b41 Mon Sep 17 00:00:00 2001 From: AnturK Date: Thu, 12 Jul 2018 09:27:25 +0200 Subject: [PATCH] Adds client byond version to feedback. (#39061) * Adds client byond version to feedback. * Duh * i need more sleep --- code/controllers/subsystem/blackbox.dm | 12 ++++++++++-- code/modules/client/client_procs.dm | 6 +++++- code/modules/client/player_details.dm | 1 + 3 files changed, 16 insertions(+), 3 deletions(-) diff --git a/code/controllers/subsystem/blackbox.dm b/code/controllers/subsystem/blackbox.dm index 409707d3da8..eec9869a1e0 100644 --- a/code/controllers/subsystem/blackbox.dm +++ b/code/controllers/subsystem/blackbox.dm @@ -68,8 +68,8 @@ SUBSYSTEM_DEF(blackbox) return FALSE return ..() -/datum/controller/subsystem/blackbox/Shutdown() - sealed = FALSE +//Recorded on subsystem shutdown +/datum/controller/subsystem/blackbox/proc/FinalFeedback() record_feedback("tally", "ahelp_stats", GLOB.ahelp_tickets.active_tickets.len, "unresolved") for (var/obj/machinery/telecomms/message_server/MS in GLOB.telecomms_list) if (MS.pda_msgs.len) @@ -77,6 +77,14 @@ SUBSYSTEM_DEF(blackbox) if (MS.rc_msgs.len) record_feedback("tally", "radio_usage", MS.rc_msgs.len, "request console") + for(var/player_key in GLOB.player_details) + var/datum/player_details/PD = GLOB.player_details[player_key] + record_feedback("tally", "client_byond_version", 1, PD.byond_version) + +/datum/controller/subsystem/blackbox/Shutdown() + sealed = FALSE + FinalFeedback() + if (!SSdbcore.Connect()) return diff --git a/code/modules/client/client_procs.dm b/code/modules/client/client_procs.dm index af2a1b2370d..6ecc63dc680 100644 --- a/code/modules/client/client_procs.dm +++ b/code/modules/client/client_procs.dm @@ -210,7 +210,9 @@ GLOBAL_LIST_EMPTY(external_rsc_urls) if(fexists(roundend_report_file())) verbs += /client/proc/show_previous_roundend_report - log_access("Login: [key_name(src)] from [address ? address : "localhost"]-[computer_id] || BYOND v[byond_version].[byond_build ? byond_build : "xxx"]") + var/full_version = "[byond_version].[byond_build ? byond_build : "xxx"]" + log_access("Login: [key_name(src)] from [address ? address : "localhost"]-[computer_id] || BYOND v[full_version]") + var/alert_mob_dupe_login = FALSE if(CONFIG_GET(flag/log_access)) for(var/I in GLOB.clients) @@ -236,8 +238,10 @@ GLOBAL_LIST_EMPTY(external_rsc_urls) if(GLOB.player_details[ckey]) player_details = GLOB.player_details[ckey] + player_details.byond_version = full_version else player_details = new + player_details.byond_version = full_version GLOB.player_details[ckey] = player_details diff --git a/code/modules/client/player_details.dm b/code/modules/client/player_details.dm index ecc113b89c0..ebe9ba91144 100644 --- a/code/modules/client/player_details.dm +++ b/code/modules/client/player_details.dm @@ -1,3 +1,4 @@ /datum/player_details var/list/player_actions = list() var/list/logging = list(INDIVIDUAL_ATTACK_LOG, INDIVIDUAL_SAY_LOG, INDIVIDUAL_EMOTE_LOG, INDIVIDUAL_OOC_LOG) + var/byond_version = "Unknown" \ No newline at end of file