From f30800d4dcf8bf6259f024bf1287f0911d332ee4 Mon Sep 17 00:00:00 2001 From: Joshua Kidder <49173900+Metekillot@users.noreply.github.com> Date: Sun, 13 Apr 2025 16:19:51 -0400 Subject: [PATCH] Subsystems meant to represent/handle in-game networks moved under their own subfolder ( no code changes ) (#90561) ## About The Pull Request While working on another PR, I noticed that there wasn't any real distinction between subsystems that function as a network for various logical components/systems in the code, and subsystems that are meant to represent what is actually an in-game network. As such, I moved what seemed to be clear representations of the functions of in-game networks under their own subfolder. This should have no effects otherwise. ## Why It's Good For The Game Per an .md I added in the folder, it helps to clearly demarcate what are backend programmatic networked systems, and what are meant to actually be a network in the game itself; the radio jammer disrupts your suit sensors and headset, not your signal relationships with DCS, and I believe having that distinction be clear at a glance of the file structure is valuable. ## Changelog :cl: Bisar code: Subsystems that are meant to represent a network in-game have been moved into their own category inside the codebase. /:cl: --- code/controllers/subsystem/networks/README.md | 9 +++++++++ .../subsystem/{ => networks}/bitrunning.dm | 0 .../subsystem/{ => networks}/circuit_component.dm | 0 .../subsystem/{ => networks}/id_access.dm | 0 .../subsystem/{ => networks}/modular_computers.dm | 0 code/controllers/subsystem/{ => networks}/radio.dm | 0 .../subsystem/{ => networks}/research.dm | 0 .../subsystem/{ => networks}/wiremod_composite.dm | 0 tgstation.dme | 14 +++++++------- 9 files changed, 16 insertions(+), 7 deletions(-) create mode 100644 code/controllers/subsystem/networks/README.md rename code/controllers/subsystem/{ => networks}/bitrunning.dm (100%) rename code/controllers/subsystem/{ => networks}/circuit_component.dm (100%) rename code/controllers/subsystem/{ => networks}/id_access.dm (100%) rename code/controllers/subsystem/{ => networks}/modular_computers.dm (100%) rename code/controllers/subsystem/{ => networks}/radio.dm (100%) rename code/controllers/subsystem/{ => networks}/research.dm (100%) rename code/controllers/subsystem/{ => networks}/wiremod_composite.dm (100%) diff --git a/code/controllers/subsystem/networks/README.md b/code/controllers/subsystem/networks/README.md new file mode 100644 index 00000000000..f1ec85a6d43 --- /dev/null +++ b/code/controllers/subsystem/networks/README.md @@ -0,0 +1,9 @@ +# Networks: Subsystems that are conceptually networked IN-GAME +### Specifically, these subsystems are for in-game mechanics that are intended to rely on a digital/radio/physical network, such as telecomms servers or the powernet + +The intent of this folder categorization is to be able to quickly reference what are intended to be in-game networks, vs what is logically networked inside the code. + +Knowing what is meant to be conceptually working off of an in-game network serves as guidance for adding or modifying features or fixing oversights and/or bugs. + +For instance, the radio jammer only affecting headsets and suit sensors could benefit from a shorthand awareness of other systems that are represented as a network, such as research. Using the radio jammer near a server or fabricator could cause it to sever its link to the supply silo or the research web. +This example is presented only as such, and not a recommendation on any new features or balance changes. diff --git a/code/controllers/subsystem/bitrunning.dm b/code/controllers/subsystem/networks/bitrunning.dm similarity index 100% rename from code/controllers/subsystem/bitrunning.dm rename to code/controllers/subsystem/networks/bitrunning.dm diff --git a/code/controllers/subsystem/circuit_component.dm b/code/controllers/subsystem/networks/circuit_component.dm similarity index 100% rename from code/controllers/subsystem/circuit_component.dm rename to code/controllers/subsystem/networks/circuit_component.dm diff --git a/code/controllers/subsystem/id_access.dm b/code/controllers/subsystem/networks/id_access.dm similarity index 100% rename from code/controllers/subsystem/id_access.dm rename to code/controllers/subsystem/networks/id_access.dm diff --git a/code/controllers/subsystem/modular_computers.dm b/code/controllers/subsystem/networks/modular_computers.dm similarity index 100% rename from code/controllers/subsystem/modular_computers.dm rename to code/controllers/subsystem/networks/modular_computers.dm diff --git a/code/controllers/subsystem/radio.dm b/code/controllers/subsystem/networks/radio.dm similarity index 100% rename from code/controllers/subsystem/radio.dm rename to code/controllers/subsystem/networks/radio.dm diff --git a/code/controllers/subsystem/research.dm b/code/controllers/subsystem/networks/research.dm similarity index 100% rename from code/controllers/subsystem/research.dm rename to code/controllers/subsystem/networks/research.dm diff --git a/code/controllers/subsystem/wiremod_composite.dm b/code/controllers/subsystem/networks/wiremod_composite.dm similarity index 100% rename from code/controllers/subsystem/wiremod_composite.dm rename to code/controllers/subsystem/networks/wiremod_composite.dm diff --git a/tgstation.dme b/tgstation.dme index 3befb3a46da..1d006d19877 100644 --- a/tgstation.dme +++ b/tgstation.dme @@ -799,10 +799,8 @@ #include "code\controllers\subsystem\atoms.dm" #include "code\controllers\subsystem\augury.dm" #include "code\controllers\subsystem\ban_cache.dm" -#include "code\controllers\subsystem\bitrunning.dm" #include "code\controllers\subsystem\blackbox.dm" #include "code\controllers\subsystem\chat.dm" -#include "code\controllers\subsystem\circuit_component.dm" #include "code\controllers\subsystem\dbcore.dm" #include "code\controllers\subsystem\dcs.dm" #include "code\controllers\subsystem\discord.dm" @@ -814,7 +812,6 @@ #include "code\controllers\subsystem\fluids.dm" #include "code\controllers\subsystem\garbage.dm" #include "code\controllers\subsystem\icon_smooth.dm" -#include "code\controllers\subsystem\id_access.dm" #include "code\controllers\subsystem\init_profiler.dm" #include "code\controllers\subsystem\input.dm" #include "code\controllers\subsystem\ipintel.dm" @@ -830,7 +827,6 @@ #include "code\controllers\subsystem\materials.dm" #include "code\controllers\subsystem\minor_mapping.dm" #include "code\controllers\subsystem\mobs.dm" -#include "code\controllers\subsystem\modular_computers.dm" #include "code\controllers\subsystem\moods.dm" #include "code\controllers\subsystem\mouse_entered.dm" #include "code\controllers\subsystem\nightshift.dm" @@ -847,9 +843,7 @@ #include "code\controllers\subsystem\profiler.dm" #include "code\controllers\subsystem\queuelinks.dm" #include "code\controllers\subsystem\radiation.dm" -#include "code\controllers\subsystem\radio.dm" #include "code\controllers\subsystem\radioactive_nebula.dm" -#include "code\controllers\subsystem\research.dm" #include "code\controllers\subsystem\restaurant.dm" #include "code\controllers\subsystem\runechat.dm" #include "code\controllers\subsystem\security_level.dm" @@ -883,7 +877,6 @@ #include "code\controllers\subsystem\vote.dm" #include "code\controllers\subsystem\wardrobe.dm" #include "code\controllers\subsystem\weather.dm" -#include "code\controllers\subsystem\wiremod_composite.dm" #include "code\controllers\subsystem\dynamic\dynamic.dm" #include "code\controllers\subsystem\dynamic\dynamic_hijacking.dm" #include "code\controllers\subsystem\dynamic\dynamic_logging.dm" @@ -900,6 +893,13 @@ #include "code\controllers\subsystem\movement\movement.dm" #include "code\controllers\subsystem\movement\movement_types.dm" #include "code\controllers\subsystem\movement\newtonian_movement.dm" +#include "code\controllers\subsystem\networks\bitrunning.dm" +#include "code\controllers\subsystem\networks\circuit_component.dm" +#include "code\controllers\subsystem\networks\id_access.dm" +#include "code\controllers\subsystem\networks\modular_computers.dm" +#include "code\controllers\subsystem\networks\radio.dm" +#include "code\controllers\subsystem\networks\research.dm" +#include "code\controllers\subsystem\networks\wiremod_composite.dm" #include "code\controllers\subsystem\persistence\_persistence.dm" #include "code\controllers\subsystem\persistence\counter_delamination.dm" #include "code\controllers\subsystem\persistence\counter_tram_hits.dm"