From f4d302d5e503a1086b7e4ca1172df421fdd86f5e Mon Sep 17 00:00:00 2001
From: SkyratBot <59378654+SkyratBot@users.noreply.github.com>
Date: Fri, 2 Dec 2022 01:01:42 +0100
Subject: [PATCH] [MIRROR] Removes Bombgers, by vibe checking your TTV bomb in
 the deep frying process [MDB IGNORE] (#17865)

* Removes Bombgers, by vibe checking your TTV bomb in the deep frying process (#71550)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

TTVs now open their valve when deep fried. This either KERBLOOEYS the
kitchen, or proves the TTV is inert, and as such we don't care if it
goes in custom food or whatever. But that's a separate problem, letting
larger items enter smaller foods, or rather letting smaller foods stay
small when large items enter them

Fixes #71547
Closes #71548

## Why It's Good For The Game

God never intended for TTVs to be turned into easily concealed,
explosively delicious food. But I like my solution more than a
blacklist~

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

:cl:
fix: TTVs can have an explosive reaction from deepfrying.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

Co-authored-by: Time-Green <timkoster1@ hotmail.com>

* Removes Bombgers, by vibe checking your TTV bomb in the deep frying process

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
Co-authored-by: Time-Green <timkoster1@ hotmail.com>
---
 code/game/objects/items/devices/transfer_valve.dm    | 10 ++++++++++
 code/modules/food_and_drinks/machinery/deep_fryer.dm |  1 -
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/code/game/objects/items/devices/transfer_valve.dm b/code/game/objects/items/devices/transfer_valve.dm
index a6377074cdb..7dee7378e6f 100644
--- a/code/game/objects/items/devices/transfer_valve.dm
+++ b/code/game/objects/items/devices/transfer_valve.dm
@@ -16,6 +16,10 @@
 	var/valve_open = FALSE
 	var/toggle = TRUE
 
+/obj/item/transfer_valve/Initialize(mapload)
+	. = ..()
+	RegisterSignal(src, COMSIG_ITEM_FRIED, PROC_REF(on_fried))
+
 /obj/item/transfer_valve/Destroy()
 	attached_device = null
 	return ..()
@@ -225,6 +229,12 @@
 /obj/item/transfer_valve/proc/c_state()
 	return
 
+///Signal when deep fried, so it can have an explosive reaction!
+/obj/item/transfer_valve/proc/on_fried(datum/source, fry_time)
+	SIGNAL_HANDLER
+	log_bomber(null, "TTV valve opened via deepfrying", src, "last fingerprints = [fingerprintslast]")
+	toggle_valve()
+
 /obj/item/transfer_valve/ui_state(mob/user)
 	return GLOB.hands_state
 
diff --git a/code/modules/food_and_drinks/machinery/deep_fryer.dm b/code/modules/food_and_drinks/machinery/deep_fryer.dm
index fbf3be54ad3..b9e395546ac 100644
--- a/code/modules/food_and_drinks/machinery/deep_fryer.dm
+++ b/code/modules/food_and_drinks/machinery/deep_fryer.dm
@@ -10,7 +10,6 @@ GLOBAL_LIST_INIT(oilfry_blacklisted_items, typecacheof(list(
 	/obj/item/reagent_containers/condiment,
 	/obj/item/delivery,
 	/obj/item/his_grace,
-	/obj/item/transfer_valve,
 )))
 
 /obj/machinery/deepfryer//SKYRAT EDIT - ICON OVERRIDEN BY AESTHETICS - SEE MODULE