From f59207ec83ccc9e3f5bd4197fe8832c523e6c94c Mon Sep 17 00:00:00 2001 From: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Date: Thu, 9 Jul 2020 00:20:46 -0700 Subject: [PATCH] Converts rad_flags to flags_1, holy shit why --- code/__DEFINES/flags.dm | 8 ++++---- code/__HELPERS/radiation.dm | 2 +- code/_globalvars/bitfields.dm | 9 ++++----- code/datums/radiation_wave.dm | 2 +- code/game/atoms.dm | 2 -- code/game/machinery/doors/airlock.dm | 3 +-- code/game/objects/structures/false_walls.dm | 2 +- code/game/objects/structures/girders.dm | 2 +- code/game/objects/structures/grille.dm | 3 +-- code/game/objects/structures/holosign.dm | 4 ++-- code/game/objects/structures/mineral_doors.dm | 2 +- code/game/objects/structures/plaques/_plaques.dm | 2 +- code/game/objects/structures/signs/_signs.dm | 2 +- code/game/objects/structures/window.dm | 3 +-- code/game/turfs/closed/_closed.dm | 2 +- code/modules/antagonists/revenant/revenant.dm | 2 +- code/modules/clothing/suits/utility.dm | 4 ++-- code/modules/mob/living/silicon/silicon.dm | 5 ++--- .../reagents/chemistry/reagents/toxin_reagents.dm | 2 +- code/modules/recycling/disposal/bin.dm | 2 +- code/modules/recycling/disposal/holder.dm | 2 +- code/modules/recycling/disposal/outlet.dm | 2 +- code/modules/recycling/disposal/pipe.dm | 2 +- 23 files changed, 31 insertions(+), 38 deletions(-) diff --git a/code/__DEFINES/flags.dm b/code/__DEFINES/flags.dm index 329269ba5d0..2f9d6e548f3 100644 --- a/code/__DEFINES/flags.dm +++ b/code/__DEFINES/flags.dm @@ -34,6 +34,10 @@ GLOBAL_LIST_INIT(bitflags, list(1, 2, 4, 8, 16, 32, 64, 128, 256, 512, 1024, 204 #define ADMIN_SPAWNED_1 (1<<15) /// should not get harmed if this gets caught by an explosion? #define PREVENT_CONTENTS_EXPLOSION_1 (1<<16) +/// should the contents of this atom be acted upon +#define RAD_PROTECT_CONTENTS_1 (1 << 17) +/// should this object be allowed to be contaminated +#define RAD_NO_CONTAMINATE_1 (1 << 18) /// If the thing can reflect light (lasers/energy) @@ -126,10 +130,6 @@ GLOBAL_LIST_INIT(bitflags, list(1, 2, 4, 8, 16, 32, 64, 128, 256, 512, 1024, 204 #define MOBILITY_FLAGS_DEFAULT (MOBILITY_MOVE | MOBILITY_STAND | MOBILITY_PICKUP | MOBILITY_USE | MOBILITY_UI | MOBILITY_STORAGE | MOBILITY_PULL) #define MOBILITY_FLAGS_INTERACTION (MOBILITY_USE | MOBILITY_PICKUP | MOBILITY_UI | MOBILITY_STORAGE) -// radiation -#define RAD_PROTECT_CONTENTS (1<<0) -#define RAD_NO_CONTAMINATE (1<<1) - //alternate appearance flags #define AA_TARGET_SEE_APPEARANCE (1<<0) #define AA_MATCH_TARGET_OVERLAYS (1<<1) diff --git a/code/__HELPERS/radiation.dm b/code/__HELPERS/radiation.dm index 6e4315cf300..6cd67d2ea14 100644 --- a/code/__HELPERS/radiation.dm +++ b/code/__HELPERS/radiation.dm @@ -18,7 +18,7 @@ if(ignored_things[thing.type]) continue . += thing - if((thing.rad_flags & RAD_PROTECT_CONTENTS) || (SEND_SIGNAL(thing, COMSIG_ATOM_RAD_PROBE) & COMPONENT_BLOCK_RADIATION)) + if((thing.flags_1 & RAD_PROTECT_CONTENTS_1) || (SEND_SIGNAL(thing, COMSIG_ATOM_RAD_PROBE) & COMPONENT_BLOCK_RADIATION)) continue processing_list += thing.contents diff --git a/code/_globalvars/bitfields.dm b/code/_globalvars/bitfields.dm index 4cfe8345a52..c9a3a7c0026 100644 --- a/code/_globalvars/bitfields.dm +++ b/code/_globalvars/bitfields.dm @@ -132,7 +132,10 @@ GLOBAL_LIST_INIT(bitfields, list( "HOLOGRAM_1" = HOLOGRAM_1, "SHOCKED_1" = SHOCKED_1, "INITIALIZED_1" = INITIALIZED_1, - "ADMIN_SPAWNED_1" = ADMIN_SPAWNED_1 + "ADMIN_SPAWNED_1" = ADMIN_SPAWNED_1, + "PREVENT_CONTENTS_EXPLOSION_1" = PREVENT_CONTENTS_EXPLOSION_1, + "RAD_PROTECT_CONTENTS_1" = RAD_PROTECT_CONTENTS_1, + "RAD_NO_CONTAMINATE_1" = RAD_NO_CONTAMINATE_1 ), "flags_ricochet" = list( "RICOCHET_SHINY" = RICOCHET_SHINY, @@ -178,10 +181,6 @@ GLOBAL_LIST_INIT(bitfields, list( "STORAGE" = MOBILITY_STORAGE, "PULL" = MOBILITY_PULL, ), - "rad_flags" = list( - "RAD_PROTECT_CONTENTS" = RAD_PROTECT_CONTENTS, - "RAD_NO_CONTAMINATE" = RAD_NO_CONTAMINATE, - ), "disease_flags" = list ( "CURABLE" = CURABLE, "CAN_CARRY" = CAN_CARRY, diff --git a/code/datums/radiation_wave.dm b/code/datums/radiation_wave.dm index 9a39f008c57..cd38c3e0955 100644 --- a/code/datums/radiation_wave.dm +++ b/code/datums/radiation_wave.dm @@ -124,7 +124,7 @@ )) if(!can_contaminate || !can_contam || blacklisted[thing.type]) continue - if(thing.rad_flags & RAD_NO_CONTAMINATE || SEND_SIGNAL(thing, COMSIG_ATOM_RAD_CONTAMINATING, strength) & COMPONENT_BLOCK_CONTAMINATION) + if(thing.flags_1 & RAD_NO_CONTAMINATE_1 || SEND_SIGNAL(thing, COMSIG_ATOM_RAD_CONTAMINATING, strength) & COMPONENT_BLOCK_CONTAMINATION) continue if(contamination_strength > remaining_contam) diff --git a/code/game/atoms.dm b/code/game/atoms.dm index 5e4033dc477..1ab512d18f9 100644 --- a/code/game/atoms.dm +++ b/code/game/atoms.dm @@ -71,8 +71,6 @@ //List of datums orbiting this atom var/datum/component/orbiter/orbiters - /// Will move to flags_1 when i can be arsed to (2019, has not done so) (2020, see previous comment) - var/rad_flags = NONE /// Radiation insulation types var/rad_insulation = RAD_NO_INSULATION diff --git a/code/game/machinery/doors/airlock.dm b/code/game/machinery/doors/airlock.dm index 3ff83aa2a3f..06ff08ee5fb 100644 --- a/code/game/machinery/doors/airlock.dm +++ b/code/game/machinery/doors/airlock.dm @@ -86,11 +86,10 @@ var/obj/machinery/door/airlock/cyclelinkedairlock var/shuttledocked = 0 var/delayed_close_requested = FALSE // TRUE means the door will automatically close the next time it's opened. - var/air_tight = FALSE //TRUE means density will be set as soon as the door begins to close var/prying_so_hard = FALSE - rad_flags = RAD_PROTECT_CONTENTS | RAD_NO_CONTAMINATE + flags_1 = RAD_PROTECT_CONTENTS_1 | RAD_NO_CONTAMINATE_1 rad_insulation = RAD_MEDIUM_INSULATION var/static/list/airlock_overlays = list() diff --git a/code/game/objects/structures/false_walls.dm b/code/game/objects/structures/false_walls.dm index e0e741d561e..e6c3b25d84c 100644 --- a/code/game/objects/structures/false_walls.dm +++ b/code/game/objects/structures/false_walls.dm @@ -22,7 +22,7 @@ smooth = SMOOTH_TRUE can_be_unanchored = FALSE CanAtmosPass = ATMOS_PASS_DENSITY - rad_flags = RAD_PROTECT_CONTENTS | RAD_NO_CONTAMINATE + flags_1 = RAD_PROTECT_CONTENTS_1 | RAD_NO_CONTAMINATE_1 rad_insulation = RAD_MEDIUM_INSULATION var/mineral = /obj/item/stack/sheet/metal var/mineral_amount = 2 diff --git a/code/game/objects/structures/girders.dm b/code/game/objects/structures/girders.dm index 096780902b2..cd7b2034e41 100644 --- a/code/game/objects/structures/girders.dm +++ b/code/game/objects/structures/girders.dm @@ -9,7 +9,7 @@ var/can_displace = TRUE //If the girder can be moved around by wrenching it var/next_beep = 0 //Prevents spamming of the construction sound max_integrity = 200 - rad_flags = RAD_PROTECT_CONTENTS | RAD_NO_CONTAMINATE + flags_1 = RAD_PROTECT_CONTENTS_1 | RAD_NO_CONTAMINATE_1 rad_insulation = RAD_VERY_LIGHT_INSULATION /obj/structure/girder/examine(mob/user) diff --git a/code/game/objects/structures/grille.dm b/code/game/objects/structures/grille.dm index 60d98cbff6d..38db8dceefa 100644 --- a/code/game/objects/structures/grille.dm +++ b/code/game/objects/structures/grille.dm @@ -5,7 +5,7 @@ icon_state = "grille" density = TRUE anchored = TRUE - flags_1 = CONDUCT_1 + flags_1 = CONDUCT_1 | RAD_PROTECT_CONTENTS_1 | RAD_NO_CONTAMINATE_1 pressure_resistance = 5*ONE_ATMOSPHERE armor = list("melee" = 50, "bullet" = 70, "laser" = 70, "energy" = 100, "bomb" = 10, "bio" = 100, "rad" = 100, "fire" = 0, "acid" = 0) max_integrity = 50 @@ -15,7 +15,6 @@ var/rods_broken = TRUE var/grille_type = null var/broken_type = /obj/structure/grille/broken - rad_flags = RAD_PROTECT_CONTENTS | RAD_NO_CONTAMINATE /obj/structure/grille/Destroy() update_cable_icons_on_turf(get_turf(src)) diff --git a/code/game/objects/structures/holosign.dm b/code/game/objects/structures/holosign.dm index 3606d7215e0..a3898e93bba 100644 --- a/code/game/objects/structures/holosign.dm +++ b/code/game/objects/structures/holosign.dm @@ -86,7 +86,7 @@ /obj/structure/holosign/barrier/engineering icon_state = "holosign_engi" - rad_flags = RAD_PROTECT_CONTENTS | RAD_NO_CONTAMINATE + flags_1 = RAD_PROTECT_CONTENTS_1 | RAD_NO_CONTAMINATE_1 rad_insulation = RAD_LIGHT_INSULATION /obj/structure/holosign/barrier/atmos @@ -97,7 +97,7 @@ anchored = TRUE CanAtmosPass = ATMOS_PASS_NO alpha = 150 - rad_flags = RAD_PROTECT_CONTENTS | RAD_NO_CONTAMINATE + flags_1 = RAD_PROTECT_CONTENTS_1 | RAD_NO_CONTAMINATE_1 rad_insulation = RAD_LIGHT_INSULATION /obj/structure/holosign/barrier/atmos/Initialize() diff --git a/code/game/objects/structures/mineral_doors.dm b/code/game/objects/structures/mineral_doors.dm index 5d81c8a30e1..1098f8cedd7 100644 --- a/code/game/objects/structures/mineral_doors.dm +++ b/code/game/objects/structures/mineral_doors.dm @@ -13,7 +13,7 @@ max_integrity = 200 armor = list("melee" = 10, "bullet" = 0, "laser" = 0, "energy" = 100, "bomb" = 10, "bio" = 100, "rad" = 100, "fire" = 50, "acid" = 50) CanAtmosPass = ATMOS_PASS_DENSITY - rad_flags = RAD_PROTECT_CONTENTS | RAD_NO_CONTAMINATE + flags_1 = RAD_PROTECT_CONTENTS_1 | RAD_NO_CONTAMINATE_1 rad_insulation = RAD_MEDIUM_INSULATION var/door_opened = FALSE //if it's open or not. diff --git a/code/game/objects/structures/plaques/_plaques.dm b/code/game/objects/structures/plaques/_plaques.dm index 07c671fc4be..cec563be8f0 100644 --- a/code/game/objects/structures/plaques/_plaques.dm +++ b/code/game/objects/structures/plaques/_plaques.dm @@ -10,7 +10,7 @@ custom_materials = list(/datum/material/gold = 2000) max_integrity = 200 //Twice as durable as regular signs. armor = list("melee" = 50, "bullet" = 0, "laser" = 0, "energy" = 0, "bomb" = 0, "bio" = 0, "rad" = 0, "fire" = 50, "acid" = 50) - rad_flags = RAD_PROTECT_CONTENTS | RAD_NO_CONTAMINATE + flags_1 = RAD_PROTECT_CONTENTS_1 | RAD_NO_CONTAMINATE_1 ///Custom plaque structures and items both start "unengraved", once engraved with a fountain pen their text can't be altered again. Static plaques are already engraved. var/engraved = FALSE diff --git a/code/game/objects/structures/signs/_signs.dm b/code/game/objects/structures/signs/_signs.dm index 88aed58229d..7a1a1ab246a 100644 --- a/code/game/objects/structures/signs/_signs.dm +++ b/code/game/objects/structures/signs/_signs.dm @@ -9,7 +9,7 @@ armor = list("melee" = 50, "bullet" = 0, "laser" = 0, "energy" = 0, "bomb" = 0, "bio" = 0, "rad" = 0, "fire" = 50, "acid" = 50) ///Determines if a sign is unwrenchable. var/buildable_sign = TRUE - rad_flags = RAD_PROTECT_CONTENTS | RAD_NO_CONTAMINATE + flags_1 = RAD_PROTECT_CONTENTS_1 | RAD_NO_CONTAMINATE_1 resistance_flags = FLAMMABLE ///This determines if you can select this sign type when using a pen on a sign backing. False by default, set to true per sign type to override. var/is_editable = FALSE diff --git a/code/game/objects/structures/window.dm b/code/game/objects/structures/window.dm index 81c00d78159..ac088f62ea2 100644 --- a/code/game/objects/structures/window.dm +++ b/code/game/objects/structures/window.dm @@ -6,14 +6,13 @@ layer = ABOVE_OBJ_LAYER //Just above doors pressure_resistance = 4*ONE_ATMOSPHERE anchored = TRUE //initially is 0 for tile smoothing - flags_1 = ON_BORDER_1 + flags_1 = ON_BORDER_1 | RAD_PROTECT_CONTENTS_1 max_integrity = 25 can_be_unanchored = TRUE resistance_flags = ACID_PROOF armor = list("melee" = 0, "bullet" = 0, "laser" = 0, "energy" = 0, "bomb" = 0, "bio" = 0, "rad" = 0, "fire" = 80, "acid" = 100) CanAtmosPass = ATMOS_PASS_PROC rad_insulation = RAD_VERY_LIGHT_INSULATION - rad_flags = RAD_PROTECT_CONTENTS var/ini_dir = null var/state = WINDOW_OUT_OF_FRAME var/reinf = FALSE diff --git a/code/game/turfs/closed/_closed.dm b/code/game/turfs/closed/_closed.dm index 407ff0ecff5..7067fcfa28e 100644 --- a/code/game/turfs/closed/_closed.dm +++ b/code/game/turfs/closed/_closed.dm @@ -3,7 +3,7 @@ opacity = 1 density = TRUE blocks_air = TRUE - rad_flags = RAD_PROTECT_CONTENTS | RAD_NO_CONTAMINATE + flags_1 = RAD_PROTECT_CONTENTS_1 | RAD_NO_CONTAMINATE_1 rad_insulation = RAD_MEDIUM_INSULATION /turf/closed/AfterChange() diff --git a/code/modules/antagonists/revenant/revenant.dm b/code/modules/antagonists/revenant/revenant.dm index 84483341c1c..35018d28742 100644 --- a/code/modules/antagonists/revenant/revenant.dm +++ b/code/modules/antagonists/revenant/revenant.dm @@ -49,7 +49,7 @@ move_resist = MOVE_FORCE_OVERPOWERING mob_size = MOB_SIZE_TINY pass_flags = PASSTABLE | PASSGRILLE | PASSMOB - rad_flags = RAD_NO_CONTAMINATE + flags_1 = RAD_NO_CONTAMINATE_1 speed = 1 unique_name = TRUE hud_possible = list(ANTAG_HUD) diff --git a/code/modules/clothing/suits/utility.dm b/code/modules/clothing/suits/utility.dm index eeed58dd552..d77f5ae412b 100644 --- a/code/modules/clothing/suits/utility.dm +++ b/code/modules/clothing/suits/utility.dm @@ -126,7 +126,7 @@ equip_delay_other = 60 flags_cover = HEADCOVERSEYES | HEADCOVERSMOUTH | PEPPERPROOF resistance_flags = NONE - rad_flags = RAD_PROTECT_CONTENTS + flags_1 = RAD_PROTECT_CONTENTS_1 /obj/item/clothing/suit/radiation name = "radiation suit" @@ -145,4 +145,4 @@ equip_delay_other = 60 flags_inv = HIDEJUMPSUIT resistance_flags = NONE - rad_flags = RAD_PROTECT_CONTENTS + flags_1 = RAD_PROTECT_CONTENTS_1 diff --git a/code/modules/mob/living/silicon/silicon.dm b/code/modules/mob/living/silicon/silicon.dm index 40e533c76b0..fa259bf360f 100644 --- a/code/modules/mob/living/silicon/silicon.dm +++ b/code/modules/mob/living/silicon/silicon.dm @@ -11,10 +11,9 @@ weather_immunities = list("ash") possible_a_intents = list(INTENT_HELP, INTENT_HARM) mob_biotypes = MOB_ROBOTIC - rad_flags = RAD_PROTECT_CONTENTS | RAD_NO_CONTAMINATE deathsound = 'sound/voice/borg_deathsound.ogg' speech_span = SPAN_ROBOT - flags_1 = PREVENT_CONTENTS_EXPLOSION_1 | HEAR_1 + flags_1 = PREVENT_CONTENTS_EXPLOSION_1 | HEAR_1 | RAD_PROTECT_CONTENTS_1 | RAD_NO_CONTAMINATE_1 var/datum/ai_laws/laws = null//Now... THEY ALL CAN ALL HAVE LAWS var/last_lawchange_announce = 0 var/list/alarms_to_show = list() @@ -33,7 +32,7 @@ var/ioncheck[1] var/hackedcheck[1] var/devillawcheck[5] - + ///Are our siliconHUDs on? TRUE for yes, FALSE for no. var/sensors_on = TRUE var/med_hud = DATA_HUD_MEDICAL_ADVANCED //Determines the med hud to use diff --git a/code/modules/reagents/chemistry/reagents/toxin_reagents.dm b/code/modules/reagents/chemistry/reagents/toxin_reagents.dm index 0842282eac0..a07d7037ef5 100644 --- a/code/modules/reagents/chemistry/reagents/toxin_reagents.dm +++ b/code/modules/reagents/chemistry/reagents/toxin_reagents.dm @@ -41,7 +41,7 @@ /datum/reagent/toxin/mutagen/expose_mob(mob/living/carbon/M, method=TOUCH, reac_volume) if(!..()) return - if(!M.has_dna() || (HAS_TRAIT(M, TRAIT_RADIMMUNE) || HAS_TRAIT(TRAIT_GENELESS) || HAS_TRAIT(M, TRAIT_BADDNA))) + if(!M.has_dna() || (HAS_TRAIT(M, TRAIT_RADIMMUNE) || HAS_TRAIT(M, TRAIT_GENELESS) || HAS_TRAIT(M, TRAIT_BADDNA))) return //No robots, AIs, aliens, Ians or other mobs should be affected by this. if((method==VAPOR && prob(min(33, reac_volume))) || method==INGEST || method==PATCH || method==INJECT) M.randmuti() diff --git a/code/modules/recycling/disposal/bin.dm b/code/modules/recycling/disposal/bin.dm index 38e8571b480..485c81e69ea 100644 --- a/code/modules/recycling/disposal/bin.dm +++ b/code/modules/recycling/disposal/bin.dm @@ -10,7 +10,7 @@ resistance_flags = FIRE_PROOF interaction_flags_machine = INTERACT_MACHINE_OPEN | INTERACT_MACHINE_WIRES_IF_OPEN | INTERACT_MACHINE_ALLOW_SILICON | INTERACT_MACHINE_OPEN_SILICON obj_flags = CAN_BE_HIT | USES_TGUI - rad_flags = RAD_PROTECT_CONTENTS | RAD_NO_CONTAMINATE + flags_1 = RAD_PROTECT_CONTENTS_1 | RAD_NO_CONTAMINATE_1 ui_x = 300 ui_y = 180 diff --git a/code/modules/recycling/disposal/holder.dm b/code/modules/recycling/disposal/holder.dm index bc1c6d549e1..16b9674c937 100644 --- a/code/modules/recycling/disposal/holder.dm +++ b/code/modules/recycling/disposal/holder.dm @@ -7,7 +7,7 @@ invisibility = INVISIBILITY_MAXIMUM resistance_flags = INDESTRUCTIBLE | LAVA_PROOF | FIRE_PROOF | UNACIDABLE | ACID_PROOF dir = NONE - rad_flags = RAD_PROTECT_CONTENTS | RAD_NO_CONTAMINATE + flags_1 = RAD_PROTECT_CONTENTS_1 | RAD_NO_CONTAMINATE_1 var/datum/gas_mixture/gas // gas used to flush, will appear at exit point var/active = FALSE // true if the holder is moving, otherwise inactive var/count = 1000 // can travel 1000 steps before going inactive (in case of loops) diff --git a/code/modules/recycling/disposal/outlet.dm b/code/modules/recycling/disposal/outlet.dm index 7f15938ca68..aa516b91fab 100644 --- a/code/modules/recycling/disposal/outlet.dm +++ b/code/modules/recycling/disposal/outlet.dm @@ -6,7 +6,7 @@ icon_state = "outlet" density = TRUE anchored = TRUE - rad_flags = RAD_PROTECT_CONTENTS | RAD_NO_CONTAMINATE + flags_1 = RAD_PROTECT_CONTENTS_1 | RAD_NO_CONTAMINATE_1 var/active = FALSE var/turf/target // this will be where the output objects are 'thrown' to. var/obj/structure/disposalpipe/trunk/trunk // the attached pipe trunk diff --git a/code/modules/recycling/disposal/pipe.dm b/code/modules/recycling/disposal/pipe.dm index b488f636798..720c29a0ff5 100644 --- a/code/modules/recycling/disposal/pipe.dm +++ b/code/modules/recycling/disposal/pipe.dm @@ -11,7 +11,7 @@ max_integrity = 200 armor = list("melee" = 25, "bullet" = 10, "laser" = 10, "energy" = 100, "bomb" = 0, "bio" = 100, "rad" = 100, "fire" = 90, "acid" = 30) layer = DISPOSAL_PIPE_LAYER // slightly lower than wires and other pipes - rad_flags = RAD_PROTECT_CONTENTS | RAD_NO_CONTAMINATE + flags_1 = RAD_PROTECT_CONTENTS_1 | RAD_NO_CONTAMINATE_1 damage_deflection = 10 var/dpdir = NONE // bitmask of pipe directions var/initialize_dirs = NONE // bitflags of pipe directions added on init, see \code\_DEFINES\pipe_construction.dm