From f6fff7de9e249247a7f792ab4007c52ceafce990 Mon Sep 17 00:00:00 2001 From: SkyratBot <59378654+SkyratBot@users.noreply.github.com> Date: Tue, 31 Jan 2023 03:15:17 +0100 Subject: [PATCH] [MIRROR] Fixes a bad assignment of parent in spirit holding component [MDB IGNORE] (#19029) Fixes a bad assignment of parent in spirit holding component (#72999) ## About The Pull Request `parent` is a reference to the datum parent of the component, but this was assigning it to a string for some reason? I just removed it. It doesn't seem to be doing anything anyways ~~I was going to make parent a private variable but too many things access it for some weird reason. Kinda wack~~ ## Why It's Good For The Game Bad code ## Changelog :cl: Melbert fix: Maybe fixes some issues with spirit holding, particularly relating to it being in-exorcism-able. /:cl: Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> --- code/datums/components/spirit_holding.dm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/code/datums/components/spirit_holding.dm b/code/datums/components/spirit_holding.dm index b32d1e83e6c..dc11d5fd729 100644 --- a/code/datums/components/spirit_holding.dm +++ b/code/datums/components/spirit_holding.dm @@ -81,8 +81,7 @@ // Now that all of the important things are in place for our spirit, it's time for them to choose their name. var/valid_input_name = custom_name(awakener) - if(parent && valid_input_name) - parent = valid_input_name + if(valid_input_name) bound_spirit.fully_replace_character_name(null, "The spirit of [valid_input_name]") attempting_awakening = FALSE