cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-24 21:48:39 +01:00
Code Issues Packages Projects Releases Wiki Activity

[no gbp] Lavaland should no longer spawn one million goliaths and watchers (#77716)

Browse Source 
## About The Pull Request

Fixes #77709

I made a very smart and sensible and handsome change in a recent PR to
replace `mob/goliath/random` and `mob/watcher/random` subtypes with
spawner effects rather than mobs which qdel themselves on init sometimes
however I neglected to account for how the lavaland map generation was
reliant on those typepaths to space mobs apart

resultingly the map generator would attempt to place lavaland mobs about
12 spaces apart _unless_ they were goliaths or watchers which it would
spawn basically as much as it wanted wherever it wanted

## Why It's Good For The Game


![image](https://github.com/tgstation/tgstation/assets/7483112/b6622b9f-f356-426c-9491-00ca4491799a)

## Changelog

🆑
fix: the goliath and watcher mating season has ended and population has
returned to normal levels
/🆑
This commit is contained in:
Jacquerel
2023-08-18 14:37:48 -06:00
committed by GitHub
parent cb4d6cfe13
commit fca0a11904
9 changed files with 64 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/game/objects/effects/spawners/random/lavaland_mobs.dm
+51
View File
@@ -0,0 +1,51 @@
/// For map generation, has a chance to instantiate as a special subtype
/obj/effect/spawner/random/lavaland_mob
name = "random lavaland mob"
desc = "Spawns a random lavaland mob."
icon = 'icons/mob/simple/lavaland/lavaland_monsters.dmi'
icon_state = "large_egg"
loot = list(
/mob/living/basic/mining/bileworm = 1,
/mob/living/basic/mining/goliath = 1,
/mob/living/basic/mining/lobstrosity/lava = 1,
/mob/living/basic/mining/watcher = 1,
/mob/living/simple_animal/hostile/asteroid/brimdemon = 1,
/mob/living/simple_animal/hostile/asteroid/goldgrub = 1,
/mob/living/simple_animal/hostile/asteroid/hivelord/legion = 1,
)
/// Spawns random watcher variants during map generation
/obj/effect/spawner/random/lavaland_mob/watcher
name = "random watcher"
desc = "Chance to spawn a rare shiny version."
icon = 'icons/mob/simple/lavaland/lavaland_monsters_wide.dmi'
icon_state = "watcher"
pixel_x = -12
loot = list(
/mob/living/basic/mining/watcher = 80,
/mob/living/basic/mining/watcher/magmawing = 15,
/mob/living/basic/mining/watcher/icewing = 5,
)
/// Spawns random goliath variants during map generation
/obj/effect/spawner/random/lavaland_mob/goliath
name = "random goliath"
desc = "Chance to spawn a rare shiny version."
icon = 'icons/mob/simple/lavaland/lavaland_monsters_wide.dmi'
icon_state = "goliath"
pixel_x = -12
loot = list(
/mob/living/basic/mining/goliath = 99,
/mob/living/basic/mining/goliath/ancient/immortal = 1,
)
/// Spawns random legion variants during map generation
/obj/effect/spawner/random/lavaland_mob/legion
name = "random legion"
desc = "Chance to spawn a rare shiny version."
icon_state = "legion"
loot = list(
/mob/living/simple_animal/hostile/asteroid/hivelord/legion = 19,
/mob/living/simple_animal/hostile/asteroid/hivelord/legion/dwarf = 1,
)