cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-22 12:41:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

Expunges if(TRUE) switch cases from the codebase (#94920)

Browse Source 
## About The Pull Request

Its a boolean, switch case only makes sense if it can be a null (which
its not in any of these cases)

## Changelog

Not player facing
This commit is contained in:
SmArtKar
2026-01-26 11:32:56 -05:00
committed by GitHub
parent 66307d27c7
commit fd1eb276ae
3 changed files with 13 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/transport/tram/tram_controller.dm
+4 -8
View File
@@ -519,15 +519,11 @@
/datum/transport_controller/linear/tram/proc/set_status_code(code, value)
if(code != DOORS_READY)
log_transport("TC: [specific_transport_id] status change [value ? "+" : "-"][english_list(bitfield_to_list(code, TRANSPORT_FLAGS))].")
switch(value)
if(TRUE)
controller_status |= code
if(FALSE)
controller_status &= ~code
else
stack_trace("Transport controller received invalid status code request [code]/[value]")
return
if(value)
controller_status |= code
else
controller_status &= ~code
send_transport_active_signal()
/datum/transport_controller/linear/tram/proc/send_transport_active_signal()
code/modules/transport/tram/tram_signals.dm
+5 -7
View File
@@ -275,13 +275,11 @@
if(updated_controller.specific_transport_id != configured_transport_id)
return
switch(new_status)
if(TRUE)
if(operating_status == TRANSPORT_REMOTE_FAULT)
operating_status = TRANSPORT_SYSTEM_NORMAL
if(FALSE)
if(operating_status == TRANSPORT_SYSTEM_NORMAL)
operating_status = TRANSPORT_REMOTE_FAULT
if(new_status)
if(operating_status == TRANSPORT_REMOTE_FAULT)
operating_status = TRANSPORT_SYSTEM_NORMAL
else if(operating_status == TRANSPORT_SYSTEM_NORMAL)
operating_status = TRANSPORT_REMOTE_FAULT
/**
* Update processing state.