From fe4481677fb4de5c2ea4c856b31264599b2c14e2 Mon Sep 17 00:00:00 2001 From: Roxy <75404941+TealSeer@users.noreply.github.com> Date: Tue, 22 Oct 2024 20:23:34 -0400 Subject: [PATCH] Fix job title in head arrival radio messages being empty (#2255) ## About The Pull Request Add back the `|| job.title` fallback for if the user isn't using an alt job title for a given job, because it went missing in https://github.com/Skyrat-SS13/Skyrat-tg/pull/23990 for some reason ## Why It's Good For The Game Fixes #2214 ## Proof Of Testing
Screenshots/Videos ![image](https://github.com/user-attachments/assets/6a857a35-1f0f-49b0-b61b-2a615be04183)
## Changelog :cl: fix: fixed department head arrival radio messages missing their job title /:cl: --- code/controllers/subsystem/job.dm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/controllers/subsystem/job.dm b/code/controllers/subsystem/job.dm index b0fb575820c..0d1152dbf63 100644 --- a/code/controllers/subsystem/job.dm +++ b/code/controllers/subsystem/job.dm @@ -561,7 +561,7 @@ SUBSYSTEM_DEF(job) /datum/controller/subsystem/job/proc/EquipRank(mob/living/equipping, datum/job/job, client/player_client) // SKYRAT EDIT ADDITION BEGIN - ALTERNATIVE_JOB_TITLES // The alt job title, if user picked one, or the default - var/alt_title = player_client?.prefs.alt_job_titles[job.title] + var/alt_title = player_client?.prefs.alt_job_titles[job.title] || job.title // SKYRAT EDIT ADDITION END equipping.job = job.title