Commit Graph
14 Commits
Author SHA1 Message Date
SyncIt21andGitHub b306c28675 General maintenance for RPD (#88047)
## About The Pull Request
**1. Code Improvement**
- Moved global pipe crafting recipe list into
`code/__DEFINES/globalvars/list` folder because its a global list & it
should belong there. Reduces size of RPD file
- Moved `datum/pipe_info` into `code/__DEFINES/globalvars` folder
because it's used by both RPD & crafting recipe so its a global var.
Reduces size of RPD file
- Replaced a bunch of `usr` with the proper user variable when available
  - Autodoc for procs & vars
 
**2. Refactor**
- Attack chain for RPD has been refactored to `interact_with_atom()` &
`interact_with_atom_secondary()`


## Changelog
🆑
refactor: improved attack chain code for rapid pipe dispenser
code: organized lists & global vars for rapid pipe dispenser into their
own respective files & improved a bunch of code
/🆑
2024-12-07 15:34:23 +01:00
31528c855e Transit Tube Fix and New Rotator Disposal Pipe (#77843)
## About The Pull Request
Fixes flipped transit tube stations being inaccessible and adds a new
rotator disposal pipe which rotates the incoming atom 90 degrees no
matter which direction the atom comes from.

![promo](https://github.com/tgstation/tgstation/assets/25363960/3cdb75f6-0540-4797-9972-935fae37db58)
## Why It's Good For The Game
Adds new disposal pipe usage for cool projects and fixes a bug.
## Changelog
🆑
add: New rotator disposal pipe.
fix: Flipped transit tube stations are now accessible in the RPD again.
image: New rotator disposal pipe sprite.
/🆑

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
2023-08-27 16:35:33 +00:00
0f435d5dff Remove hideous inline tab indentation, and bans it in contributing guidelines (#56912)
Done using this command sed -Ei 's/(\s*\S+)\s*\t+/\1 /g' code/**/*.dm

We have countless examples in the codebase with this style gone wrong, and defines and such being on hideously different levels of indentation. Fixing this to keep the alignment involves tainting the blames of code your PR doesn't need to be touching at all. And ultimately, it's hideous.

There are some files that this sed makes uglier. I can fix these when they are pointed out, but I believe this is ultimately for the greater good of readability. I'm more concerned with if any strings relied on this.

Hi codeowners!

Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
2021-02-14 16:53:29 -08:00
Cruixandduncathan salt 47a57f63c5 Added transit tubes to the RPD (#35074) 2018-02-04 02:44:59 -06:00
ACCountandJordan Brown 8b5cd7f7dc Disposal pipes and pipe dispensers refactor (#32435)
* Disposal pipes and pipe dispensers refactor

* Disposal pipes refactor, phase 2: Reviewing Intensifies

* More code review edits

* Changes hasmob check loop

* There was a point when we should have stopped, and we have clearly passed it.
2017-11-12 01:30:17 -05:00
duncathan saltandoranges e8c2109ea0 Atmos construction rework again (#31944)
* initial atmos construction commit ft todo list

* cleans up pipe/construction.dm

* compile

* rpd tgui

* revert rpd tgui because no icon support zzzzzz

* fixes RPD

also fixes the one RPD bug i caused the last time i touched pipe construction where you'd get null pipes if you switched from disposals to atmos pipes

* cleanup
2017-10-24 10:29:36 +13:00
orangesandduncathan salt 193aa45bc1 Revert bluespace pipes while keeping fixes from the original PR (#31866)
These are absurdely overpowered given that they have no research or
material gate
2017-10-19 15:39:03 -06:00
kevinz000andduncathan salt cd5f983da4 Atmospherics Multilayer Pipes (#30972)
* 1

* rpd

* 3

* 4

* 5

* 6

* 7

* 8

* wew

* src. and underlays

* update

* woops

* misspelled params

* reviews

* fixes

* fixes

* better checks and layer crap

* Update RPD.dm

* Update pipe_construction.dm

* 3 layers, fixes

* woops i didn't update defines correctly

* dunc

* Fixes

* Fixes

* fixes

* fixes some more bullshit

* fixes

* fixes

* not needed

* makes attachment sprites prettier or uglier i dunno

* Unary flag

* sprite fix??

* fixes...

* sprite fixes
2017-10-16 23:48:48 -06:00
pubby b653e2b387 Adds bluespace pipes 2017-09-18 06:57:56 -05:00
Core0verloadandduncathan salt 0fd0c991a8 Gas injectors are now buildable (#26474)
* Injectors are now constructable and deconstructable

* Gives injectors TG UI, fixes a bug with MAX button not working for volumetric pumps
2017-04-26 03:35:27 -06:00
phil235 b0b5a90bd7 Requested changes 2016-11-03 19:03:04 +01:00
duncathan 3e4299105d adds heat exchanging manifolds, both 3-way and 4-way 2015-09-06 15:06:59 -06:00
duncathan e84ca7365a fixes merge stuff 2015-08-17 16:48:34 -06:00
duncathan d320c4c945 first pass of cleaning up construction.dm + merge from upstream 2015-08-14 20:55:09 -06:00