Commit Graph
12 Commits
Author SHA1 Message Date
RoxyandGitHub 504a8461ec Move pixel shift keybinds/signals to /mob/living (#4167)
## About The Pull Request

Move keybind signal defines and `/datum/keybinding`s to be living
instead of mob

## Why It's Good For The Game
Fixes #4164

## Proof Of Testing

Tested on local no runtimes and still functions

## Changelog

No user facing changes
2025-07-02 22:07:04 -04:00
RoxyandGitHub 44ba6f63bd Fix incorrect pixel shift behavior for mobs with nonzero base pixel x/y (#3352)
## About The Pull Request

When I was reworking the pixel shift component to accommodate upstream
changes to mob pixel offset behavior I changed it to track offset in the
component instead of reading pixel x/y directly, but forgot to remove
the calculations that take the base pixel x/y into account, which would
no longer be needed

## Why It's Good For The Game

Fixes #3341 

## Proof Of Testing

<details>
<summary>Screenshots/Videos</summary>


![image](https://github.com/user-attachments/assets/2c12155f-2c8f-4867-ab48-f687b191a71e)

</details>

## Changelog

🆑
fix: fixed larger sprite size mobs being unable to pixel shift properly
/🆑
2025-03-23 19:48:08 -07:00
nevimer 368543b6fd GallowsCalibrator and Waterpig's fixes, but squash 2025-03-16 01:55:41 -04:00
OdairuandGitHub 42dee590e6 optimizes pixel shifting some (#29231)
the whole PR
2024-08-06 23:08:09 +02:00
Odairu 4ab49e3415 the whole PR 2024-08-05 22:16:44 -04:00
3eb53be29e [REFACTOR] Pixel Shift Component (#22564)
* Pixel Shift - Move to Component

* oops return ais

* more refactor

* update authors

* remove more unused signals!

* one more little refactor

* update override and readme

* update dme

* move addcomponent to login

* review

* more review fixes

* more changes, now qdels on unpixel_shift

* remove unnecessary

* update readme

* return signal

* update documentation?

---------

Co-authored-by: Bloop <vinylspiders@gmail.com>
2023-08-05 14:56:24 -04:00
56d1f36654 [MODULAR] [HOST REQUEST] Pixel Shift Out of the Way! (#15175)
* Out of the way pixel shift? No way!

* Push suggestions and a logic fix!

* *Much* better logic!

* Oops comment!

* Apply suggestions!

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Document var!

Website moment!

* Apply suggestions!

* Fix inaccurate comment!

* Update modular_skyrat/modules/pixel_shift/code/pixel_shift.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2022-08-27 15:56:42 -04:00
9c53a34072 [MIRROR] Removes some unused mob verbs + client vars [MDB IGNORE] (#12438)
* Removes some unused mob verbs + client vars (#65732)

* Removes an unused var from /client
`inprefs` isn't used anywhere, i checked to when it was added (~5 years
ago) and it wasn't even really used then. I think it used to be used to
track topic calls / slowdown some href issues but it isn't any more.
Byebye!!

* Removes some unused mob verbs + client var
`canface` and `east/west/north/southface` used to be used to set
direction but these are no longer used and are thus taking up
unnecessary space

* Removes some unused mob verbs + client vars

* Update pixel_shift.dm

Co-authored-by: Seth Scherer <supernovaa41@gmx.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-04-01 01:52:26 +01:00
Seris02andGitHub fab444ffe2 [modular] big borg code improvements and fixes (#9701)
* big borg code improvements and fixes

* I missed a modular comment

* fuck you linters

* yis

* converts skyrat versions to better

* annnnnd that should fix it
2021-12-01 21:06:59 -05:00
AzarakandGitHub 1ae9add3bf [SEMI-MODULAR] Combat Indicator (#1678)
* aaa

* a
2020-11-12 06:12:25 +00:00
8db24d79e6 [MIRROR] Fix royal alien pixel offset, change getter to variable (#1641)
* Fix royal alien pixel offset, change getter to variable (#54706)

Fixed a bug where royal aliens would have their base pixel offset applied twice, making them off-center (https://i.imgur.com/BtspaM0.png)

Changed the mob/living procs get_standard_pixel_x_offset() and get_standard_pixel_y_offset() to variables (body_position_pixel_x_offset and body_position_pixel_y_offset), to match the contribution guidelines.

Also corrected a few random things that weren't using base pixels but should have been.

* Fix royal alien pixel offset, change getter to variable

* Update pixel_shift.dm

Co-authored-by: Yenwodyah <yenwodyah@gmail.com>
Co-authored-by: Azarak <azarak10@gmail.com>
2020-11-11 02:47:05 +00:00
7818dac725 [SEMI-MODULAR] PIXEL-SHIFTING module (#870)
* sif

* Update pixel_shift.dm

* Refactor

* Update code/modules/mob/mob_movement.dm

Co-authored-by: Azarak <azarak10@gmail.com>

* Update modular_skyrat/modules/pixel_shift/code/pixel_shift.dm

Co-authored-by: Azarak <azarak10@gmail.com>

* Update modular_skyrat/modules/pixel_shift/code/pixel_shift.dm

Co-authored-by: Azarak <azarak10@gmail.com>

* oops

* Update modular_skyrat/modules/pixel_shift/code/pixel_shift.dm

Co-authored-by: Azarak <azarak10@gmail.com>

* Update modular_skyrat/modules/pixel_shift/code/pixel_shift.dm

Co-authored-by: Azarak <azarak10@gmail.com>

* Update modular_skyrat/modules/pixel_shift/code/pixel_shift.dm

Co-authored-by: Azarak <azarak10@gmail.com>

* Update mob_movement.dm

* fuckywucky

* omg

* aaaaaaaaaa

* Update mob_movement.dm

* Update modular_skyrat/modules/pixel_shift/code/pixel_shift.dm

Co-authored-by: Azarak <azarak10@gmail.com>

* Update modular_skyrat/modules/pixel_shift/code/pixel_shift.dm

Co-authored-by: Azarak <azarak10@gmail.com>

* Update modular_skyrat/modules/pixel_shift/code/pixel_shift.dm

Co-authored-by: Azarak <azarak10@gmail.com>

* Update pixel_shift.dm

Co-authored-by: Gandalf <jzo123@hotmail.com>
2020-09-27 23:37:37 +02:00