## About The Pull Request
Fix the ready button
## Why It's Good For The Game
The people want to be ready
## Proof Of Testing
Trust me
## Changelog
🆑
fix: fixed ready button on title screen
/🆑
## About The Pull Request
Fixes#2023
Readying up when the game is in the START: SOON phase can spawn you
naked in the interlink with nothing.
This PR blocks the player from being able to join when it says START:
SOON as this can cause many code issues down the line.
They will either have to ready up before START: SOON or late-join,
otherwise they are stuck respawning anyways or ahelp and will explain
below why.
When players clicked "ready up" just as the game entered the
GAME_STATE_SETTING_UP state, they would be marked as ready but not
properly initialized with their equipment.
This happens because:
The HUD button for ready-up correctly disables when the round starts,
However, the Topic handler in the Skyrat title screen module
(/mob/dead/new_player/Topic with the toggle_ready href) didn't check the
game state.
This allowed a race condition where a player's click could pass through
the handler after the round had already begun setting up, the player
would then get marked as ready but not go through the proper
equip_characters() procedure, spawning them naked on the interlink
I have tested this, if you try to ready up when it says round starting
soon, you will remain in the lobby, thus preventing this bug from being
able to happen.
## Why It's Good For The Game
This bug is still in the game and kind of annoying when you spawn with
absolutely nothing on interlink, you can't open any doors and are stuck.
This makes the player confused, forces them to ahelp or get answers if
they are stuck, and inevitably respawn to fix the problem. This check
will circumvent that entirely, also encourages people to ready-up early
or latejoin.
## Proof Of Testing
Tested the PR on my server. I readied up as soon as I saw it say
Starting Round: SOON cause that's how I had gotten this bug reproduced
on live before. Now it blocked me from joining the round, just leaving
me at the lobby screen even though the job slot was open.
## Changelog
🆑 Soot-IX
fix: Joining during Round: SOON would cause player to spawn with nothing
at all. Now prevents player from readying up during this phase to stop
this bug.
/🆑
## About The Pull Request
Fixes loading map specific title screens, which was omitted for some
reason when the HTML title screen was created.
## Changelog
🆑 LT3
server: Title screens can now be assigned to a specific map
/🆑
Apparently the live server (only one of the two) secretly had a fix for the transparency thing already in the config but never committed to git, so changes the values to match those
## About The Pull Request
`.menu_button` was being affected by the `.container_nav` opacity
property because the former is contained in the latter, changes the
styling to stop using the opacity property and shift the opacity change
to `container_nav`'s `background` property for the same effect. Also
deletes the unused skyrat titlescreen config file
## Why It's Good For The Game
Fixes#3235
## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>
</details>
## Changelog
🆑
fix: fixed title screen stylesheet making the menu buttons semi
transparent
/🆑
## About The Pull Request
The timetable has been accelerated
## Why It's Good For The Game
Yes
## Proof Of Testing
Yes
## Changelog
🆑 Bubberstation Staff
balance: Time is almost up.
/🆑
## About The Pull Request
Add watermark to unvetted clients, add warning to unvetted clients when
attempting to join the game, eventually locking out access on September
1st. Add warning text to examine for unvetted clients
## Why It's Good For The Game
The time has come
## Proof Of Testing
Tested it extensively last night
## Changelog
🆑 Bubberstation Staff
add: The clock is ticking.
/🆑
## About The Pull Request
516 fucked with href stuff and so this request never sends and the
client is never marked ready so init loading messages don't get sent
## Why It's Good For The Game
Cool live loading messages
## Proof Of Testing
This is a web edit from bed that I tested earlier and it worked
## Changelog
🆑
fix: fixed loading screen not updating as subsystems init
fix: fixed character name on title screen not updating when changing
slots
/🆑
## About The Pull Request
Removes an unused skyrat subsystem that asked players for their DOB on
first connection, we are whitelist-only and do vettings manually over
discord so there's no need for this and it has never been enabled
anyways
## Why It's Good For The Game
Remove unused subsystem and dead code
## Proof Of Testing
It works no runtimes
## Changelog
No player facing changes
## About The Pull Request
"I'm going to extend my break" - Me, 2 days ago
"Hey I should start cleaning up the Skyrat modular folder" - Me, Today
I yet again fall victim to my own hubris
Left out some BUBBER TODOs, feel free to do these if you find them
manageable
## Why It's Good For The Game
We made some old mistakes with some edits (Like commenting out ruins
instead of making them unpickable for the ruin system) (This I fixed,
admins can now bus them in!)
We also made a lot of edits to Skyrat code, a lot of which can be
cleanly merged into their code now
## Proof Of Testing
If it compiles, it works.
Unlike my modularization PR from a year ago this is less fuckupable
## Changelog
N/A, not player facing
This reverts commit 499e688291.
## About The Pull Request
We love unannounced changes directly to the master branch. Gotta be my
favorite gender
## Why It's Good For The Game
There is a thing known as "Terrible UI design" and a Marquee is very
much part of the things you do NOT want to use under any circumstance.
(Aside from a meme with the announce/narrate verbs)
Please the lobby now looks way too dumb
## Proof Of Testing
A revert.
## Changelog
🆑
fix: Fixes horrendous ui design
/🆑
* Admin Verb Datums MkIII | Now with functional command bar (#82511)
* Modular stuffs
* Put some admin jump verbs back into the context menu | sorts area jump list again (#82647)
## About The Pull Request
See title.
## Why It's Good For The Game
Some admins wanted all the jump verbs back, aswell as making them not
AGhost you.
Also make the Jump To Area verb use a sorted list again
* Hey what if admins were allowed to use the player panel (#82682)
Re-adds the player panel verb to the verb panel.
* Controller Overview UI (#82739)
* Fixes a minor spelling mistake on the admin panel/verb list (#82747)
## About The Pull Request
Corrects `inisimin` to `invisimin`. This addresses #82728, but only
fixes one of the two issues mentioned
## Why It's Good For The Game
-1 spelling mistake
## Changelog
🆑
spellcheck: 'inisimin' verb corrected to 'invisimin'
/🆑
* Player Panel-age (#82757)
* Admin Forced Mob Rename and Preference Update (#82715)
---------
Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
Co-authored-by: chel <64568243+iliyaxox@users.noreply.github.com>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
I honestly forgot what I changed, but thankfully Visual Studio Code
tells me what I changed.
This PR makes it so that autopunctuation properly checks the pref again.
Additionally, all Advert preferences have been moved to a new game
preferences category: ADVERT.
Second to last, the Character Directory will now show on the Title
Screen under the Crew Manifest.
Finally, The character directory's sort function has been repaired, and
it has received two extra buttons:
One, a search bar, which allows you to search characters by name.
Two, a randomizer, which selects a random player's flavor text and opens
it for you. Feeling lucky?
<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->
## Why It's Good For The Game
This makes the Character Directory more intuitive and accessible, while
also adding some new, fun stuff to work with.
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Proof Of Testing
<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑 ReturnToZender (code)
fix: Character Directory sorting now works on all variables.
fix: autopunctuation respects prefs again
qol: Advert settings have been moved to a new category, ADVERT.
add: Character directory now has a search function on the name var.
add: Character directory now shows on the Main Menu under the Crew
Manifest.
add: Character directory now has a randomizer, which will open a random
player's flavor text when clicked. Click if you dare.
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->
---------
Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
A while ago, I created Silicon Flavortext requirements. However, I had a
minor oopsie. In the ready up checks, I made it so that the
uses_normal_flavortext variable would check your normal flavor text, but
if you didn't have enough, say you lacked silicon flavor text rather
than the intended regular flavor text. This PR fixes that.
<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->
## Why It's Good For The Game
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
It's good for players to know what the real issue is here.
## Proof Of Testing
<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->
Normal character:
<img width="284" alt="image"
src="https://github.com/Bubberstation/Bubberstation/assets/110273561/9ce21b14-5d77-48df-823e-18bd26c02927">
Silicon character:
<img width="285" alt="image"
src="https://github.com/Bubberstation/Bubberstation/assets/110273561/bac778d6-2bf9-4938-b7a9-9933c7945a09">
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑 ReturnToZender
fix: Readying up without proper flavor text now reports the correct
flavor text source instead of saying you need silicon flavor.
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->
---------
Co-authored-by: Esixdotnet <156951974+Esixdotnet@users.noreply.github.com>
Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
Co-authored-by: The Sharkening <95130227+StrangeWeirdKitten@users.noreply.github.com>
Co-authored-by: Bubberbot <151680451+Bubberbot@users.noreply.github.com>
Co-authored-by: thegrb93 <grbrown93@sbcglobal.net>
Co-authored-by: BurgerLUA <8602857+BurgerLUA@users.noreply.github.com>
* Initial commit, not even half-done yet
* A second commit as I stumble towards a working solution
* Theeere we go, another step , I suppose
* fixes and one prompt per player
* yaya
* a
* okaaay, a step further
* not done yet but soon
* Theeere we go...
* feeex
* no interact till ss done
* Update maturity_subsystem.dm
* Okay, maybe it works now
* Ready for tests
* At last... now to test with a db.
* oh well, it's not like it needs to be the first one to init
* undoes the changelog clusterfuck
* now undoes it for real
* autoformatter-b-gone
* okay we don't want it on by default
* Well, it is ambiguous now that I look at it.
* Okay, now it should work 95%
* Oh well
* This should be straight up faster
* y u no auto tick
---------
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
## About The Pull Request
This PR adds NSFW flavor text, and adds it to the examine panel. It also
adds preferences for when NSFW flavor text shows and doesn't show on a
per character basis: Always On, Nude Only, and Never.
The flavor text is in a dropdown, so people can't be flashbanged by borg
cock. It even has a silicon flavor text variant!
PR is tested and ready for testmerge.
Also akes it so the minimum flavor text check applies to silicons!
Pictured: 300 characters of regular flavor text, but no silicon flavor
text
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->
## Why It's Good For The Game
ERP rule 4 is no longer necessary after this, reducing rules bloat.
Additionally, this will increase the roleplay standard by separating
NSFW and regular flavor texts. Gone are the days of 4 paragraphs of ERP
text making up for your lack of writing skill.
And finally, this will make it so you are no longer flashbanged with
NSFW details once and for all. Simply do not click the reveal button,
and all will be hidden to you.
Additionally, Silicons are required to have 300 characters of flavor
text, but not of the type that actually relates to their job. This gives
silicons similar roleplay standards to everyone else.
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->
## Changelog
<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->
🆑 ReturnToZender, LT3, Waterpig
add: NSFW flavor text (for players and silicons)
add: New examine panel with slightly bigger font, easier to read, also
integrates most of the new preferences
add: Flavor text requirements now respect silicon flavor text, thanks to
@lessthnthree
/🆑
<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->
---------
Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
Co-authored-by: StrangeWeirdKitten <95130227+StrangeWeirdKitten@users.noreply.github.com>
Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
## About The Pull Request
Moves the loading/title splash CSS and HTML to its own file in the
bubbers config directory, allowing the server to modify it as they
please without worrying about upstream.
Tidies up the loading screen CSS and matches the colors with the main
menu.
## Why It's Good For The Game
Better CSS, creates a distinct visual identity, more moff.
https://github.com/Bubberstation/Bubberstation/assets/83487515/3f038003-b735-4cc3-9599-da541dfbd4d2
## Changelog
🆑 LT3
code: Loading and title splash are now modularized
/🆑
* TGUI Latejoin Menu!
* [PR PR] Fixes up the TGUI Latejoin Menu! (#18044)
* Makes Angel, Dragon and Robotic wings available in the preferences menu again (#18013)
Makes Angel, Dragon and Robotic wings available in the prefs menu again
* Automatic changelog for PR #18013 [ci skip]
* [MIRROR] Petrified human statues now drop a (stone) brain on destruction [MDB IGNORE] (#18026)
* Petrified human statues now drop a (stone) brain on destruction (#71816)
## About The Pull Request
Destroying a petrified human statue will now drop their brain, albeit a
little more statue-like.
Changed from original PR after talking w/ Fikou about it
## Why It's Good For The Game
While the combo *does* step on the toes of Smite, the statue+rod combo
is capable of fully removing you from the round without a way back very
quickly. This keeps the strength of the combo while not making it
entirely impossible to get back into the round.
## Changelog
🆑
balance: Destroying a petrified human statue will now drop their brain.
/🆑
* Petrified human statues now drop a (stone) brain on destruction
Co-authored-by: Zonespace <41448081+Zonespace27@users.noreply.github.com>
* Automatic changelog for PR #18026 [ci skip]
* [MIRROR] Chaplain armor beacon now uses radial + previews possible armor sets, plus some choice beacon code cleanup. [MDB IGNORE] (#18019)
* Chaplain armor beacon now uses radial + previews possible armor sets, plus some choice beacon code cleanup. (#71674)
## About The Pull Request
- The chaplain choice beacon now uses a radial to select the armor set,
instead of a list, giving the user a preview of what each looks like.
- Lots of additional cleanup to choice beacon code in general. Less copy
pasted code.
- All beacons now speak from the beacon with their message, instead of
some going by "headset message". Soul removed
## Why It's Good For The Game
I always forgot when selecting my armor which looks like what, and
choosing an ugly one is a pain since you only get one choice. This
should help chaplains get the armor they actually want without needing
to check the wiki.
## Changelog
🆑 Melbert
qol: The chaplain's armament beacon now displays a radial instead of a
text list, showing previews of what all the armor sets look like
qol: (Almost) all choice beacons now use a pod to send their item,
instead of just magicking it under your feet
code: Cleaned up some choice beacon code.
/🆑
Co-authored-by: Fikou <23585223+Fikou@ users.noreply.github.com>
* Chaplain armor beacon now uses radial + previews possible armor sets, plus some choice beacon code cleanup.
* update modular
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: Fikou <23585223+Fikou@ users.noreply.github.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
* Automatic changelog for PR #18019 [ci skip]
* [MIRROR] Fixed an improper proc ref. [MDB IGNORE] (#18031)
Fixed an improper proc ref.
Co-authored-by: lizardqueenlexi <105025397+lizardqueenlexi@users.noreply.github.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
* Automatic changelog for PR #18031 [ci skip]
* Fiiix!
* Fuck
* [MIRROR] Windoors are vulnerable to a jaws of life [MDB IGNORE] (#18040)
* Windoors are vulnerable to a jaws of life (#71733)
## About The Pull Request
Windoors can be pried by a jaws of life now
## Why It's Good For The Game
Windoors are already immune to any kind of deconstruction outside of
bashing it, so making it immune to the jaws of life as well seems
excessive
## Changelog
🆑
balance: jaws of life can pry windoors
/🆑
Co-authored-by: Candycaneannihalator <candycane@ thisisnotarealaddr.com>
* Windoors are vulnerable to a jaws of life
Co-authored-by: texan-down-under <73374039+etherware-novice@users.noreply.github.com>
Co-authored-by: Candycaneannihalator <candycane@ thisisnotarealaddr.com>
* Automatic changelog for PR #18040 [ci skip]
* Automatic changelog compile [ci skip]
* [fix] fixes det revolver icons (#18049)
* Delete guns.dmi
* Add files via upload
* Automatic changelog for PR #18049 [ci skip]
* [MIRROR] Fixes fake links in Adminwho that led to "no_feedback_link" [MDB IGNORE] (#18027)
* Fixes fake links in Adminwho that led to "no_feedback_link" (#71804)
## About The Pull Request
Basically, sometimes, very rarely, it was possible for this to happen,
when it shouldn't be happening. I was wondering for a little while what
it was about, and then I finally downloaded my chat logs for a round and
realized what was going on. It should no longer happen.
## Why It's Good For The Game
Clickable links that lead nowhere (and thus don't do anything) aren't
very good for the game.
## Changelog
🆑 GoldenAlpharex
fix: There shouldn't be clickable names in Adminwho that don't do
anything anymore.
/🆑
* Fixes fake links in Adminwho that led to "no_feedback_link"
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
* Fix: Self-Actualization Device Doubling Damage (#18015)
* Change adjustOrganLoss/BruteLoss/FireLoss to set
* Reverts my naive soluton
* Automatic changelog for PR #18027 [ci skip]
* Automatic changelog for PR #18015 [ci skip]
* Fix TGUI latejoin menu not closing properly, properly this time
* Oh yea, flavourtext requirement exists. Not that we actually have it enabled upstream.
* Revert "Merge remote-tracking branch 'upstream/upstream-merge-71883' into fixlatejoinmenu"
This reverts commit 3279e73418f95637162a2923b0431e9e26b43403, reversing
changes made to d46aab7b421fee94d49b57e863bfd8e0917fc43f.
* Fucking stupid code merge shit
* Cool newline bro
* Dumb stupid commented code
* Also this
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
Co-authored-by: SkyratBot <59378654+SkyratBot@users.noreply.github.com>
Co-authored-by: Zonespace <41448081+Zonespace27@users.noreply.github.com>
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: Fikou <23585223+Fikou@ users.noreply.github.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
Co-authored-by: lizardqueenlexi <105025397+lizardqueenlexi@users.noreply.github.com>
Co-authored-by: texan-down-under <73374039+etherware-novice@users.noreply.github.com>
Co-authored-by: Candycaneannihalator <candycane@ thisisnotarealaddr.com>
Co-authored-by: Changelogs <action@github.com>
Co-authored-by: RatFromTheJungle <62520989+RatFromTheJungle@users.noreply.github.com>
Co-authored-by: Dani Glore <fantasticdragons@gmail.com>
Co-authored-by: distributivgesetz <distributivgesetz93@gmail.com>
* fix
Co-authored-by: Rimi Nosha <riminosha@gmail.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
Co-authored-by: Zonespace <41448081+Zonespace27@users.noreply.github.com>
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: Fikou <23585223+Fikou@ users.noreply.github.com>
Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>
Co-authored-by: lizardqueenlexi <105025397+lizardqueenlexi@users.noreply.github.com>
Co-authored-by: texan-down-under <73374039+etherware-novice@users.noreply.github.com>
Co-authored-by: Candycaneannihalator <candycane@ thisisnotarealaddr.com>
Co-authored-by: Changelogs <action@github.com>
Co-authored-by: RatFromTheJungle <62520989+RatFromTheJungle@users.noreply.github.com>
Co-authored-by: Dani Glore <fantasticdragons@gmail.com>
Co-authored-by: distributivgesetz <distributivgesetz93@gmail.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
