Commit Graph
4 Commits
Author SHA1 Message Date
StrangeWeirdKitten f20222d6e9 removes trait_mute from voidwalker trauma
Update adv_plasmacutter_upgrade.dm
2024-07-25 10:42:27 -06:00
StrangeWeirdKitten 5326c2d89d Couple fixes
couple fixes

fixes cyborg module sprites

Entombed fix + handheld scanner

last one
2024-07-25 10:42:26 -06:00
d96b2b97aa Waterpig grows more insane with modularity: The massive PR that probably breaks shit (#838)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

I have circuitry theory finals in 1 hour. And as such, to distract
myself from my impending doom and to stop thinking about loop currents,
I have decided to start working on this. (Update: I passed)

This isn't even close to how I wish our modularity to look

But that's future Waterpig's problem (Note to self: Fix the no_antag
button)

In another news, this probably breaks stuff.

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->

## Why It's Good For The Game

Modularity is good. The more stuff we can modularize the better, and
incase it gets removed upstream it's as simple as... removing our
modular override.
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and it's effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑
refactor: Refactors modularity significantly
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->

---------

Co-authored-by: The Sharkening <95130227+StrangeWeirdKitten@users.noreply.github.com>
2023-12-19 07:41:04 -07:00
StrangeWeirdKittenandGitHub c8a522084f Removes Engineering Cyborg Electric Welder (+ modularization) (#597)
## About The Pull Request

**This PR Primarily removes the borg electric welder.** (If this is such
a hot debate, I'll atomize the below changes later)

I've also taken the initiative to add some modularization to the
codebase by moving all the techweb stuff to ``New()`` inside our
all_nodes folder with the borg plasma cutter.

Basically, modularize the tech web and designs.

## Why It's Good For The Game

Basic code organization and modularization put away,

The Electric Welder is powerful. It is extremely powerful. It is an
infinite charge almost no delay welder from skyrat with a tool speed of
0.2 given to a machine that can use it to repair itself to full health
in one second. I think the ability of an engineering cyborg to run into
combat, fight a blob, pull back, and repair itself to full health
without any expenditure of welding fuel nearby or time, is a severe
balance issue. This should not have been added to the game. It also
makes a very decent melee weapon since it's not going to run out of
fuel.

## Changelog

🆑 StrangeWeirdKitten
del: Engineering borgs no longer have an electric welder upgrade. 
refactor: Modularized and moved all our techweb edits into one folder. 
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
2023-10-08 18:55:19 -04:00