## About The Pull Request
fixes#90586
## Why It's Good For The Game
the poster isnt _that_ wanted
## Changelog
🆑
fix: Wanted posters now correctly return to your inventory if you move
while placing them
/🆑
---------
Co-authored-by: Xerseon <138307753+Xerseon@users.noreply.github.com>
## About The Pull Request
spacemandmm, and byond, did not used to error on using `for init; test,
inc`. spacemandmm now does, and i think it's bad syntax to keep around
anyway
## Why It's Good For The Game
this syntax was mad
## Changelog
no playerfacing changes
Co-authored-by: harryob <55142896+harryob@users.noreply.github.com>
* Posters return to your hand when cut down/not hung up, abductor posters more resilient to wirecutters (#81924)
## About The Pull Request
Posters now drop into your hand when you cancel the hanging process, or
snip them down with wirecutters. If they can't drop into your hands,
they go to the floor.
Oh, also, this makes it so that abductor wirecutters (or any wirecutters
with a toolspeed better than 0.2 in case of varedits/future additions)
are too weak to cut down abductor posters.
## Why It's Good For The Game
Posters getting dropped to the ground when cancelling the hanging
process has always really annoyed me and I want it to not happen
anymore.
If you want to get those unsightly abductor posters out of your
department you'll have to loot the abductor scientist first (or just
take the wall down but that's admitting defeat).
## Changelog
🆑 Rhials
qol: Posters now return to your hand when the hanging process is
cancelled, or they are snipped down.
qol: Abductor posters can now only be cut down with abductor-tier
wirecutters.
/🆑
* Posters return to your hand when cut down/not hung up, abductor posters more resilient to wirecutters
---------
Co-authored-by: Rhials <28870487+Rhials@users.noreply.github.com>
* converts contraband file into poster file, makes holiday posters work (kind of) (#72131)
## About The Pull Request
The first part of this is just something that bothered me when I was
messing around with something that I will PR in the new year,
contraband.dm and dmi is ONLY posters. There's nothing else in there and
there are plenty of official posters, and if with #71717 we will also
add holiday posters to the mix then I think that its time to retire
contraband and make it poster.
Some small things I did while messing with it was change some variables
that were single letters into actual variable names, but overall this
part of the pr is not a player facing change.
That said, speaking of #71717 I think that it didn't work? Or didn't
work the way that it was supposed to? All of the spawned posters aren't
instances of festive posters, they are instances of normal posters, so
the code on initialize was not doing anything and the only reason the
holiday_none poster was showing up was because of the proc in randomize
spawning the posters in as those other posters. Because it didn't
actually _become_ poster/official/festive it never could do the proc
that turns it into a poster for the holiday that is actually occurring.
But then when I made it work and it turned into the generic posters I
decided that it would be better if instead of 30% of all posters being a
half finished mess, that if there wasn't a holiday poster it just
wouldn't replace them at all. I have poster Ideas and Dreams so I will
try to help with adding to more holiday posters but not in this PR.
What IS in this PR though, is a new traitor poster that appears during
the holidays.
This is a generic evil holiday poster that will replace normal evil
posters in the evil poster objective, because I agree with #72003 that
it should be a feature.
## Why It's Good For The Game
Contraband file is just posters already, this is easier for people to
find the posters.
I like holiday posters and think that we should have them and add more,
it is a fun easy thing to add to a lot of the microholidays to make them
more visible in addition to the name generation, but I don't want to see
the unfinished holiday poster so I do think that it's better to only
have them spawn if the holiday actually has a poster. Looking forward to
febuary!
## Changelog
🆑
add: during holidays the spread syndicate propaganda through posters
objective has a chance of spawning evil holiday poster
fix: framework for holiday posters is more functional and modular
code: contraband.dm file and contraband.dmi file are both now poster.dm
and poster.dmi
/🆑
* converts contraband file into poster file, makes holiday posters work (kind of)
Co-authored-by: Sol N <116288367+flowercuco@users.noreply.github.com>
* poster fixes (#69956)
fuck poster code. whole thing needs a rewrite imo.
Fixes#69954
cl ShizCalev
fix: Wanted/missing posters are no longer broken.
fix: Missing posters no longer change text color after being taken down.
fix: Posters no longer fail to get put up 4 seconds after you walk away while placing them lol
/cl
* poster fixes
Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
* Posters refactor
- Posters now use a simple type-per-poster definition, rather than some
large global lists requiring sprite numbers to be the same as entries in
a list.
- Putting a specific poster on a map now simply means putting the
specific type that you want, rather than var editing (often
unsuccessfully).
- There are random all-posters, random contraband posters, and random
official posters for mappers too.
- Ripped posters are now their own type.
- The potential to make additional classes of posters has been left
open, I'd like to move a bunch of the advertisement posters to their own
catagory, and clean up the "official" category to be more obviously
on-brand.
* Updates DeltaStation
* Changed the maps of Metastation
* OmegaStation posters updated
* Updated Pubby posters
* Map merged?
* Updated away mission and ruin posters
* Removes vars from garbage
DresserOnFire
