5 Commits

Author SHA1 Message Date
SkyratBot e1c3bf0b6d [MIRROR] Adds support for different achievement dmis (#26517)
* Adds support for different achievement dmis (#81471)

## About The Pull Request

I am back to pushing my code improvements upstream, sorry in advance.
As the title says, this adds support for achievement icons to be in
different dmi files than the default, pretty much the exact same way
that Language icons (for chat assets) do.

## Why It's Good For The Game

It is one of the few things in game (the only other thing i can think of
that does this rn is barsigns) that cannot have their icon changed when
trying to make a subtype, this is very limiting and very annoying,
especially since dmi conflicts are one of the worst types to deal with,
this would make my life a lot easier.

## Changelog

No player-facing changes.

* Adds support for different achievement dmis

---------

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2024-02-15 17:39:52 -05:00
SkyratBot f4ff22e017 [MIRROR] Achievements now show how many people have unlocked them. [MDB IGNORE] (#23344)
* Achievements now show how many people have unlocked them. (#77083)

## About The Pull Request
Checking the achievements UI now shows a line below the Unlocked/Locked
status for normal achievements, informing the user of how many players
have unlocked said achievement. It also contains a tooltip; within it is
a percentile comparison with the most unlocked achievement.

Beside that, I've added a check in the achievement unit test to
ascertain that all award categories are actually present in the UI, and
as well moved all `ui_data` to `static_ui_date` considering it is not
the sort of interface that has to be constantly updated like an air
alarm or an APC.

Here's a screenshot of the UI, with the tooltip where my cursor would be
(the hot damn! achievement was var-edited of course):
![Hot damn
th](https://github.com/tgstation/tgstation/assets/42542238/d80bfe3a-e755-4036-a360-276d5d3395dc)

## Why It's Good For The Game
This should provide some fundamental statistics for achievements, from
which contributors and players can deduct the rarity and bragging
rights.

## Changelog

🆑
qol: The Achievements UI now shows how many people have unlocked a given
achievement.
fix: The "Skills" Category for achievements should no longer be hidden.
/🆑

---------

Co-authored-by: san7890 <the@ san7890.com>
Co-authored-by: Jordie0608 <4343468+Jordie0608@ users.noreply.github.com>

* Achievements now show how many people have unlocked them.

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Co-authored-by: san7890 <the@ san7890.com>
Co-authored-by: Jordie0608 <4343468+Jordie0608@ users.noreply.github.com>
2023-08-26 10:49:51 -07:00
SkyratBot 7947051eab [MIRROR] Adds unit test to check for spritesheet issues [MDB IGNORE] (#16774)
* Adds unit test to check for spritesheet issues (#70351)

* Adds a new spritesheet unit test to catch edge-cases that caused problems in the past.

* Adds unit test to check for spritesheet issues

Co-authored-by: AnturK <AnturK@users.noreply.github.com>
2022-10-11 17:47:01 +01:00
Tastyfish f322eaff57 [MIRROR] Makes integration test results be in color and have annotations (#13341) 2022-05-05 19:10:20 -04:00
SkyratBot 4b14699c6a [MIRROR] Fixes missing award icons by filling the assets list on runtime. Plus new icons and unit test. [MDB IGNORE] (#9340)
* Fixes missing award icons by filling the assets list on runtime. Plus new icons and unit test.

* Feexing conflicts

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2021-11-09 09:40:55 -05:00